search

chinedufn / percy

Build frontend browser apps with Rust + WebAssembly. Supports server side rendering.
https://chinedufn.github.io/percy/
Apache License 2.0
2.26k stars 84 forks source link

Fix router-rs for path segments on the same level #90

Closed cryptoquick closed 5 years ago

cryptoquick commented 5 years ago

This is a fun one. Perplexingly, the router was handing me the same route for routes that were different.

I can't vouch for the correctness of this routing code, that would take many more comprehensive tests, but it works much better now.

chinedufn commented 5 years ago

Thanks for catching this!

Those router.rs tests are starting to get duplicative and can probably be refactored into a re-usable structure like we do elsewhere

But this works for now - sweet catch !!!