search

chinedufn / skeletal-animation-system

A standalone, stateless, dual quaternion based skeletal animation system built with interactive applications in mind
https://chinedufn.github.io/skeletal-animation-system/
250 stars 24 forks source link

New site #7

Closed mdkq closed 6 years ago

mdkq commented 6 years ago

Currently just have a placeholder img for the demo, but the div#canvas can just be changed to canvas#canvas (without changing any formatting) and it should work fine.

There's currently 2 togglable buttons for the demo (wave and walk) but we can add more if you want.

Also there's no build chain or package management it's all static......... sry 😛

Untested on real mobile env but tests in chrome device view all looked good.

mdkq commented 6 years ago

So the standard check is failing in the new build because it can't tell that anime.js is installed via cdn.. any idea what to do?

chinedufn commented 6 years ago

@mdkq you can replace anime with window.anime and it should work because:

  1. window is an allowed global variable in Standard style
  2. All global variables can be accessed in the browser's global context (window)
chinedufn commented 6 years ago

@mdkq looks like the pull request is now closed - any reason for that or accidental?

chinedufn commented 6 years ago

Nice work on all of this!

I've added you as a collaborator to skeletal-animation-system - when you're ready feel free to merge this in!

mdkq commented 6 years ago

I found a fix for that janky scrollTop check that I half implemented last night but it broke some things so I just gotta clean that up. It was passing tests so I didn't want you to merge it by accident

And thanks! I should have it merged today