search

chinese-words-separator / chinese-words-separator.github.io

5 stars 1 forks source link

Zhuyin side display unable to hide annotation for learned words #18

Closed supercontingency closed 1 year ago

supercontingency commented 1 year ago

The new side display of Zhuyin looks great and is much much easier to read. I really think it should be the default way Zhuyin is annotated (make horizontal annotation an option). Thank you so much for making it possible. However I do notice that when I select side annotation of Zhuyin I can not choose to hide annotation for learned words.

Horizontal Annotation of Zhuyin, hide learned words

Screenshot 2023-03-19 9 41 59 PM_2

Learned words are not annotated, nor colored

Screenshot 2023-03-19 9 56 10 PM_2

However if I select side annotation of Zhuyin, everything else being the same

Screenshot 2023-03-19 9 43 45 PM_3

now the learned words are not colored, but the annotation remains

Screenshot 2023-03-19 9 43 32 PM_2

I'm sure this is a easily fixable glitch

chinese-words-separator commented 1 year ago

I'm sure this is a easily fixable glitch

Not a glitch, the mechanism for left/right zhuyin is totally different from under/above zhuyin. The left/right annotation's code barely reused the code of under/above annotation mechanism, especially that the latter is word-based(can be multi-syllables). The left/side annotation is a totally new functionality, I overlooked the exclude learned mechanism for left/right zhuyin. Anyway, made the necessary changes so that exclude learned works on left/right zhuyin too, it's on 8.24.84.1320

I really think it should be the default way Zhuyin is annotated (make horizontal annotation an option)

No need to make left/right the default when choosing Zhuyin, it's a confusing UX as it breaks symmetry. Besides, Safari has a bug that renders complex layout totally wrong, e.g., when choosing to display the left/right zhuyin on vertical writing system

image

I don't want Safari users to be welcomed by that atrocity when Left/Right is made the default when they chosen Zhuyin as a Guide. Safari is really the new IE

If the Under/Above is the default regardless of chosen Guide..

image

..then Safari users have a usable default when left/right (under/above technically) Zhuyin functionality is used on vertical writing system

image

It's good that at least Left/Right Zhuyin is totally fine when using horizontal writing mode

image

Thank you so much for making it possible

Thanks too, you're welcome