chinese-words-separator / chinese-words-separator.github.io

5 stars 1 forks source link

word search not working for compound words when CWS is on #20

Closed supercontingency closed 1 year ago

supercontingency commented 1 year ago

I noticed ever since adding the side annotation of Zhuyin I can't search for compound phrases on Chrome. Here is for example a search for the single character "於 ". Chrome is able to find this character with Zhuyin

https://photos.app.goo.gl/JP6frEAonqRP6yiaA

but now the compound word "屬於" in the same location it is not able to find.

https://photos.app.goo.gl/St6wSMQj66hHpbXx8

I need to do this to add the word to the learned word list. There does not seem to be a simple way to add the word directly from the ALL HSK list to the Learned Word List. I need to 1) find the word in the text and 2) double click on the word. It would be great if we could directly add words from the All HSK List to the Learned Word List and also have a column in the Learned Word List denoting the date it was learned/added to track progress

chinese-words-separator commented 1 year ago

but now the compound word "屬於" in the same location it is not able to find. https://photos.app.goo.gl/St6wSMQj66hHpbXx8

This is a browser limitation, in this case it's a limitation of Chrome. Safari on the other hand can search compound words just fine

image

Better to file this issue on Chrome's feature request or bug fix request

It would be great if we could directly add words from the All HSK List to the Learned Word List

There's already a mechanism to mark learned words without clicking them one-by-one, make a newline-delimited list of words you already knew/learned, copy it, and then click Restore learned from clipboard. e.g., copy the list below..

屬於
小公主
电脑

..and then click the Restore learned from clipboard button

image

Then those words will be marked as learned

image

chinese-words-separator commented 1 year ago

and also have a column in the Learned Word List denoting the date it was learned/added to track progress

I will put this in separate issue. Currently, under-the-hood, learned words are just marked with a boolean denoted by 'Y'. Many parts of CWS will be impacted when it is changed to date