chinese-words-separator / chinese-words-separator.github.io

5 stars 1 forks source link

More detailed description of the issue described in the review in which a new element x-x impedes entering more data in the textbox #29

Open julodnik2 opened 1 week ago

julodnik2 commented 1 week ago

Hi, thanks for commenting in my review. I understood your explanation and I was able to find the element x-x which I can delete to be able to enter data again in the google translate box. These are my settings: image image image And this is how I use google translate: image after entering the string in the Chinese field, as soon as I press the ctrl key to copy the text out of it (even it is configured to only appear with Ctrl and Alt), the new element x-x appears: image if I release ctrl or click somewhere else, the popup disappears, but the element x-x does not If I remove the element x-x manually I can continue working with google translate. So in my opinion the event that removes/hides the popup should remove the element x-x as well.

Thanks for your great work and super fast support!

chinese-words-separator commented 1 week ago

Implemented your suggestion three days ago, it's in version 8.24.84.2460. It now removes the x-x element when the pop-up disappears, then made it refocuses the text cursor to its last position so there's no need to click the text

However, CWS version 8.24.84.2450 is still in Pending Review. Google usually finish reviewing extensions in just a day. There are times that they do full review of the extensions though. I feel it's like random, in my experience it's like they are doing full review of the extension about four times a year. Will again ask Google support when it's still not yet approved after seven days. Will upload 8.24.824.2460 as soon as 8.24.84.2450 got approved for publishing

Uploaded CWS on Edge add-ons store three days ago too, Edge takes longer than Google to review extensions but Edge consistently finished reviewing extension on seventh day and get it published, CWS 8.24.84.2460 will be available on September 20 on Edge add-ons store

The CWS 8.24.8402460 for iOS and macOS Safari are already published. Apple review apps/extensions faster than Google, it just takes them about half a day, rare for them to exceed a day

chinese-words-separator commented 5 days ago

8.24.84.2461 is now published. Just wait for CWS to get updated automatically by Chrome; don't remove then add the extension, your CWS settings and data will get reset and cleared doing that

julodnik2 commented 5 days ago

It got updated. But the element x-x is still there when the dictionary popup disappears :-( Maybe there is anything wrong with my settings?

chinese-words-separator commented 5 days ago

Hmm.. I did not test the update well. The element x-x gets deleted when the pop-up disappears, but this only happens when you don't move the mouse cursor inside the dictionary. The x-x element can get deleted though whether you move the mouse cursor inside the dictionary or not, this can be accomplished by pressing the Escape key

I will fix the problem, but for the meantime, to make both the pop-up dictionary and x-x element disappear, press Escape key instead

chinese-words-separator commented 11 hours ago

The problem is fixed in 8.24.84.2470. Editing of text can be resumed even if the mouse cursor is moved inside the dictionary as long as mouse cursor is moved outside the dictionary afterwards, then the x-x element gets deleted when the dictionary disappears

Let me know if you still experiences some glitches when you resume editing the text

julodnik2 commented 7 hours ago

Hmm, it does not really work yet. My use case is still the same, as long as the popup appears over the text box then I won't be able to continue entering data in the textbox. Sometimes (the first time normally) it works if I press escape to close the popup, but subsequent times won't work. This is especially annoying for Google Translate, because I use it as IME for Chinese, so I write text there and when I try to copy the text out of it I will press Ctrl and that will show the dictionary popup. Afterwards no input is possible.

Maybe it would be an idea to have an option to disable the popup on textboxes? Some other popup dictionaries offer this option and until now I never understood why. Since a textbox is usually data entered by the user, it is unlikely that they need to use the dictionary over their own entered data.

chinese-words-separator commented 4 hours ago

Since a textbox is usually data entered by the user, it is unlikely that they need to use the dictionary over their own entered data.

I feel it's quite the contrary, I see some users of other dictionary extensions are now complaining that the dictionary they are using is no longer working properly anymore in text boxes, including Google Translate's text box. It's handy for them to paste large portion of text to Google Translate, but they still need to know which Chinese word map corresponds to which English word in the translated English text, so they use pop-up dictionary on the Chinese text that they pasted to Google Translate's text box to achieve that. Example:

image

This is especially annoying for Google Translate, because I use it as IME for Chinese, so I write text there and when I try to copy the text out of it I will press Ctrl and that will show the dictionary popup. Afterwards no input is possible.

Hmm.. that is strange, pressing the Ctrl key by itself won't trigger the activation of CWS's pop-up dictionary. CWS's pop-up dictionary is not designed to activate in text boxes that way. It's intrusive if the dictionary will pop up just because the Ctrl key is pressed, as there are many functionalities that uses Ctrl key as shortcut, e.g., paste (Ctrl+V), copy (Ctrl+C), search or type URL in Chrome's address bar (Ctrl+L). The dictionary will only be shown when pressing the Ctrl key AND hovering the mouse cursor over Chinese characters, both must happen so the dictionary will pop up. Never had any experience that pressing Ctrl key alone will show CWS's pop-up dictionary

By any chance are you hovering the mouse cursor over the Chinese text while you hold the Ctrl key? CWS's pop-up dictionary will be shown if that is what is happening

I think you are using the CWS's Ctrl key to select text. Don't use that, it does not select the actual text in the text box, CWS just highlights its own text, the overlaid text (I mentioned this in my reply to you in CWS's Chrome Web Store page), which is just overlaid on top of the actual text. It looks like text selection, but CWS is just highlighting the text in the overlaid text, it is not selecting the actual text in the text box

To select and copy Chinese text (actual text in text box) without using mouse, press Shift key, then use Right Arrow key (or use End key), then press Ctrl+V. Let me know if this works

But if CWS's pop-up dictionary still activated even when you don't use mouse and you are just pressing Ctrl key; if you don't mind, can you make a video demonstration how it happens? So I can reproduce the problem on my side. Thanks

julodnik2 commented 3 hours ago

I think you are using the CWS's Ctrl key to select text. Don't use that, it does not select the actual text in the text box, CWS just highlights its own text, the overlaid text (I mentioned this in my reply to you in CWS's Chrome Web Store page), which is just overlaid on top of the actual text. It looks like text selection, but CWS is just highlighting the text in the overlaid text, it is not selecting the actual text in the text box

I am using shift to select the text while I move my mouse, then I press Ctrl+C to copy the selected text to the clipboard. While I press Ctrl my hand is still on the mouse, so very likely it will move slightly and the popup appears. So yes, I could change my way of working, but after so many years... not easy. The settings of the plugin are set to use ctrl and alt for the popup dictionary, in the textbox this is not honored. The popup appears by just pressing Ctrl. Is this intended?