search

chingfeng / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

Review New 2.x Branch of vt-catalina with AsyncJDBCAccessLogValve Component #137

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:

Develop additional Tomcat components to include in library.  Note bump to 
dependency on Tomcat 7.x.

When reviewing my code changes, please focus on:

AsyncJDBCAccessLogValve

After the review, I'll merge this branch into:
/trunk

That is, if you like the idea of increasing the scope of the library to Tomcat 
extension components generally.

Original issue reported on code.google.com by marvin.addison@gmail.com on 7 Sep 2012 at 6:22

GoogleCodeExporter commented 8 years ago 
Assigning to Daniel.

Original comment by marvin.addison@gmail.com on 7 Sep 2012 at 6:23

GoogleCodeExporter commented 8 years ago 
Consider having the LogEntry properties mirror those of the request object.
Should the inner class LogEntry be public?
Consider exposing a property that sets the ExecutorService.
Code should pass checkstyle rules before it is merged into trunk.
+1 on expanding the scope of the library.
It has no where to go but up.

Original comment by dfis...@gmail.com on 27 Nov 2012 at 3:49