chingu-voyage3 / fair-rentals

Fair Rentals - an anonymous rental reviews site
https://fair-rentals.herokuapp.com/
2 stars 0 forks source link

Return to Location/:id page after login #34

Closed shoesandsocks closed 6 years ago

shoesandsocks commented 6 years ago

Currently login always returns user to root. This is fixable with some react-router work, I think.

shoesandsocks commented 6 years ago

one solution may be to return history.go(-2); instead of pushing '/' onto history. exploring better option though. Need the branch that reworks initial signup to be merged before fixing this.

shoesandsocks commented 6 years ago

while on this issue let's look at where a new user lands on first login. Should be on Profile instead of Splash?

shoesandsocks commented 6 years ago

I made a tweak to your 34-redirect branch, that avoids the brief display of the Splash page before the history.go function redirects the user. just returning the axios call, to avoid the return at the end of the function (which is now unreachable, so i deleted it)

I think that one's ready to merge too.