search

chingu-voyage4 / Bears-Team-18

Voyage-4
0 stars 1 forks source link

Testing #10

Closed Jarrku closed 6 years ago

Jarrku commented 6 years ago

What are we gonna do about testing? Do I include a testing setup and do we expect a decent code coverage on each PR?

LydiaVuj commented 6 years ago

TravisCI? elaborate on decent code coverage pls

hienng commented 6 years ago

If we're gonna do testing, then TDD it is.

BenGitter commented 6 years ago

No experience with testing... I can of course read into it when we decide what we use for testing.

Jarrku commented 6 years ago

TravisCI is something like CircleCI so its one or the other really.

You can check test coverage (the amount of lines of code that the tests you've written cover) on each PR automatically by a GitHub integration so it would yell at you if you try to commit something thats below the testing treshold.

Im fine with no tests either but it might be a nice addition to get the full experience?

LydiaVuj commented 6 years ago

i would implement testing. good experience as you said

Jarrku commented 6 years ago

Ok what kind of coverage do expect on each PR then? 70-80%?

Jarrku commented 6 years ago

Also testing framework? I've used Jest before and pretty well for me :)

Jarrku commented 6 years ago

Anyone any preference on framework?

BenGitter commented 6 years ago

No preference, Jest looks nice.