chingu-voyage5 / Bears-Team-6

Add-project-description-here | Voyage-5 | chingu.io
0 stars 0 forks source link

Setup/add config #14

Closed aaronmassey45 closed 6 years ago

Faxn commented 6 years ago

I would have gone with require('dotenv').config()

Minor issues:

That said I don't think it's worth worrying about, so of you both are happy with this approach then I'll say no more about it. If you are more comfortable with this system go ahead with it.

aaronmassey45 commented 6 years ago

Added some code so they variables can't be overwritten and commented so it's easier to understand. If we are setting any env variables to an array we need to rethink how we are doing things.

I'm not a fan of adding modules for things we can easily do ourselves and I don't think "requires more explanation" is a justification to add dotenv. But if that's easier for you guys to work with, I'm ok with making the switch.

aaronmassey45 commented 6 years ago

PR has been approved. Merging and closing branch