chingu-voyage5 / Geckos-Team-34

Book Finder | Voyage-5 | chingu.io
5 stars 4 forks source link

Find and return link to buy books from Amazon or Google Books #7

Open adeen-s opened 6 years ago

adeen-s commented 6 years ago

Please write the User story for this feature As a user, I want to be able to buy a book from the website so that I can read it later.

Describe the solution you'd like A clear and concise description of what you want to happen. Find and return link to buy books from Amazon or Google Books

danivijay commented 6 years ago

Didn't tried this before, would like to. As I'm already doing the authentication part. So I can do this after completing that, if possible. What do you think @adeen-s ?

ahegazy commented 6 years ago

@danivijay I think it's more related to the searching part .. the mark part though is related to the singup/login

danivijay commented 6 years ago

@ahegazy I din't worked with APIs of Amazon and Ebay. But I would like to. That's why asked. However if someone else up for it, feel free to.

adeen-s commented 6 years ago

@danivijay you have been assigned to the login/signup functionality right now. You can work on this after you have done that, since there are 5 issues and 4 people so it will be available for you later.

adeen-s commented 6 years ago

@Shivam60 you indicated that you were working on this issue. Would you like me to assign this to you?

Shivam60 commented 6 years ago

@adeen-s i have made progress, its almost complete for the google api. I am just cleaning the code and dealing with one issue. i ll post asap

adeen-s commented 6 years ago

@Shivam60 I think you misunderstood. I am not asking you to finish the work quickly. I just wanted you to assign an issue to yourself, which you have already done.

Shivam60 commented 6 years ago

So guys here is what i have done till now. for a given ISBN i use google API to find its corresponding google web page and from there i scrape the websites. (because google API doesn't provide links for websites directly)

ahegazy commented 6 years ago

@Shivam60 so the good thing is i get the corresponding google web page of the book have a look at 'book.vue' and the function at action.js so you can work from there ... the bad thing is that happens only if the book at the search page was found at googlebooks but if it was found at goodreads some books don't have purchase links but the good thing here too is that goodreads api offers purchase links here it called 'book buy link' in the result so you can use that in goodreads case .. have a look at goodreads function in 'actions.js'