search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

add components & basic layout for landing page #29

Closed snrelghgub closed 3 years ago

snrelghgub commented 3 years ago

Our basic page layout has the following React component structure for our App /> as we agreed yesterday:

Navbar /> Header /> Search /> --> SeachBar /> Result /> --> Card /> Footer /> *where SearchBar /> is a child component of Search /> & Card /> is a child component of Result /> **please also note I decided to use the name Card /> instead of Volume /> to separate & isolate our dependency on Google Books API's naming conventions in its data model.

Thanks in advance for reviewing my PR & providing me with your feedback.

ArunJose commented 3 years ago

Instead of naming the component Results I would suggest to pick a more suitable name like BookCardList/BookCard, BookList/BookListItem, CardList/Card, BookCards/BookCard etc. We can can probably reuse the same component in other places like when displaying books in favorites. Also, it will more accurately describe what the component is rendering.

snrelghgub commented 3 years ago

that's really smart suggestion @ArunJose. I updated to CardList/Card already - I definitely agree that it is a more appropriate name combination to represent its reusability. Thanks for your constructive input 👍