search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Card component #34

Closed ghost closed 3 years ago

ghost commented 3 years ago

The Card component doesn't appear on the page because the volumes array in CardsList is empty. To test Card, populate the volumes array with props for a Card, eg

export default function CardList() {
  const volumes = [{ title: "Foo", authors: ["Bar", "Baz"] }];
  const card = (volume) => <Card {...volume} />;
  return <div>{volumes.map(card)}</div>;
}
snrelghgub commented 3 years ago

hello @willnwhite Your PR is linked to the issue "Display Search Results" which requires the books matching the search criteria display in an infinite scroll, but your PR does not resolve the issue. Please review your code or requirements or let me know or anyone else on our team if you need any assistance with resolving your assigned issue 👍

ghost commented 3 years ago

Still no infinite scroll but user can see search results on page.

ghost commented 3 years ago

Infinite scroll moved to #39 so this branch can be merged now.