search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Feature/navbar #38

Closed Guitarhub786 closed 3 years ago

Guitarhub786 commented 3 years ago

This PR addresses; Create navigation bar component #28

Created basic Navbar with placeholder links (until we know what the link features/components names are). I have created version1 of our logo already. However, for this sprint, I have used a text-based logo as a placeholder.

I have stopped here as this is the first time team is integrating first code sprint so as to minimise merge conflict. As we still need to finalise details like style and file/folder structures etc.

Guitarhub786 commented 3 years ago

You can ignore that. That was done in our meeting remember. With Jim we were configuring Netlify and we needed to push a change. In a file even if you type anything or even a 'space' and revert it back to normal. Git will still recognise that as a change in ($ git status). You can then 'push' changes, even though there is nothing there.

Hence, what you saw with '+' in .gitignore diff file in Github.

ghost commented 3 years ago

Ah, okay. I remember the conversation, I just wasn't watching. I thought I'd be able to edit it out of the file on github, but it's not there. I'll merge now.