search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

add style to header title to match logo, add font link to index.html #45

Closed Guitarhub786 closed 3 years ago

Guitarhub786 commented 3 years ago

Add style to head title to match logo text. As imported same fonts from font google to display/match same as logo. Improve user style experience. As it is text, will maintain aspect ratio without the need to use/insert an image.

image.png

image.png

Guitarhub786 commented 3 years ago

I have already raised that point in the meeting after you had to leave. I implemented the same solution for my logo in 'navbar' component branch. Because if people just created their own file structure without agreement, I was afraid of merge conflicts as and when we all merge to 'development' branch.

My solution, for now, was to use 'inline' variable styling as not to pollute other parts of code. Once everything is merged, and file structure and styling is normalised, we can refactor into relevant files. Though, Jim explained that inline styling can also be a solution and practise in itself.