search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Feature/infinite scroll search results #48

Closed ghost closed 4 years ago

ghost commented 4 years ago

Though there are UI enhancements to make, like showing that results are loading, I thought I'd PR this now since the basic feature is working (and therefore offers value to the user). More commits could be made on this branch to make those enhancements, and then they could be merged into development subsequently. It would just save opening up another branch for the UI enhancements.

ArunJose commented 4 years ago

Infinite scrolling is working properly in Firefox.

I couldn't get infinite scrolling working in Chrome, both in live predeployment, and when running locally. No infinite scrolling occurs with live predeployment and infinite scrolling stops at second page when running locally. I'm not sure whether the issue is specific to my installation of Chrome, we need to check it with other team members.

ArunJose commented 4 years ago

Hi, @snrelghgub. I didn't come across that error. For me, on Microsoft Edge, infinite scrolling isn't working. Are you getting this error on all searches or only on specific searches? I would like to reproduce that error to look it into further and to check whether that bug exists also in development branch.

snrelghgub commented 4 years ago

@ArunJose I used very basic input test strings "test", "javascript" - everything seem to work fine until I attempt to rapidly scroll down a few pages but then the app breaks & all I see is a blank HTML page & the Type error message in the console. when you say that the infinite scrolling doesn't work on your side. can you elebarote exactly what happens? do you get a blank landing page too? what do you see in the console?

ArunJose commented 4 years ago

@snrelghgub When I say infinite scrolling doesn't work for me in Microsoft Edge, I mean only the first search page is loading and it doesn't load the next page on scrolling to the bottom. And I don't see the TypeError warning in console when scrolling to the bottom. The app works as expected but only shows first 40 items i.e. without infinite scrolling

But I was able to replicate this bug in development branch (on Chrome) with search term "test" and clicking on more button repeatedly. I will work on a fix for this bug. Thank you for reporting this.

ghost commented 4 years ago

Infinite scrolling is working properly in Firefox.

I couldn't get infinite scrolling working in Chrome, both in live predeployment, and when running locally. No infinite scrolling occurs with live predeployment and infinite scrolling stops at second page when running locally. I'm not sure whether the issue is specific to my installation of Chrome, we need to check it with other team members.

@ArunJose Did #50 fix this too?