search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Diemention results loading notification #63

Closed Guitarhub786 closed 4 years ago

Guitarhub786 commented 4 years ago

An option to use component 'select/option' instead of 'radio buttons'. Like the previous 'radio' option, 'select' is set default to 'relevance', and user can change to 'newest' before or after initial search.

ghost commented 4 years ago

Upside: the drop-down takes up less space than the two radio buttons Downside: the user has to click on the drop-down to see what options they have

Guitarhub786 commented 4 years ago

A) "Upside: the drop-down takes up less space than the two radio buttons B) "Downside: the user has to click on the drop-down to see what options they have"

Agreed. My thoughts are if we're going to only have 'two' options for MVP then stick to 'radio' buttons. But if you intend to add more options, then having dropdowns start to make sense.

jdmedlock commented 4 years ago

Closing since it's already implemented from another PR