search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Add, remove and display favorites #70

Closed ArunJose closed 3 years ago

ArunJose commented 3 years ago

Changes

This PR is addresses issues #7 and #6

ghost commented 3 years ago

Woah! Books Plus suddenly grew up! Nice work @ArunJose.

I've noticed two problems.

  1. I got a blank page when I logged in when I was on the Favorites page.
  2. The search results were gone when I went back to the Home page from Favorites.

I'm not sure if these issues should be fixed on this branch before merging it, or opened as new issues for new bugfix branches.

ArunJose commented 3 years ago

Woah! Books Plus suddenly grew up! Nice work @ArunJose.

I've noticed two problems.

  1. I got a blank page when I logged in when I was on the Favorites page.
  2. The search results were gone when I went back to the Home page from Favorites.

I'm not sure if these issues should be fixed on this branch before merging it, or opened as new issues for new bugfix branches.

Thanks @willnwhite. Much of the work done in this PR was done in collaboration with @mokokom.

  1. You need to have some favorites added, otherwise it is displaying a blank page. I'll add an info message to make it clear to the user.
  2. I'll look into fixing it in this PR itself. Otherwise, will make another PR.

Thank you for the feedback.