Feature/partway down page load results

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/

GNU General Public License v3.0

1 stars 1 forks source link

Feature/partway down page load results #71

Closed ghost closed 3 years ago

ghost commented 3 years ago

Works, but more than one request is made (bug). Opening PR so this can be merged into development early if desired.

ghost commented 3 years ago

The second request is made because, when scrolling fast enough, a scroll happens before areResultsLoading in handleScroll is set to true by setAreResultsLoading(true) in useEffect in useBookSearch. This is because useEffect is asynchronous.

ghost commented 3 years ago

Closed because the effort required to fix this bug in the time left before the project deadline was not worth the benefit of the feature (as discussed with @jdmedlock).