chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Bug/absent data handling #73

Closed mokokom closed 3 years ago

mokokom commented 3 years ago

@willnwhite and I have fixed the issue with absent data and how to handle it in frontend during our pair programming. Also @ArunJose mentionned an issue with unsecure image link URL. This PR resolve this too by changing all image URL from HTTP to HTTPS.

ArunJose commented 3 years ago

image

On details page author info and publisher info are missing but it's shown in the card component.

Absent data handling on the card component works good.

image

Here are a few things I've noticed with the image:

One other improvement that could be made is changing date format. It seems unclear what 1988/1/2 could mean. A better format would be like "2 Jan 1988".

In deploy preview the image links still aren't updated, it's still requesting http images and the warnings are still shown in console.

ghost commented 3 years ago

A search for "dragon force" shows that this fixes linked issue #72. I'm happy for this to be merged.

mokokom commented 3 years ago

thank you for your feedback. @ArunJose, I will fix the issues you've mentioned. About HTTP URLs I made a mistake in calling the method on infoLink and I only called it in the Modal component and not in Cart. I think this should be fixed at the next PR.

mokokom commented 3 years ago

@ArunJose I added your suggestions and fixed the issues you mentioned. Let me know if you still see any issues Capture d’écran 2020-11-11 à 16 23 46 Capture d’écran 2020-11-11 à 16 23 26