Closed mokokom closed 3 years ago
On details page author info and publisher info are missing but it's shown in the card component.
Absent data handling on the card component works good.
Here are a few things I've noticed with the image:
One other improvement that could be made is changing date format. It seems unclear what 1988/1/2 could mean. A better format would be like "2 Jan 1988".
In deploy preview the image links still aren't updated, it's still requesting http images and the warnings are still shown in console.
A search for "dragon force" shows that this fixes linked issue #72. I'm happy for this to be merged.
thank you for your feedback. @ArunJose, I will fix the issues you've mentioned. About HTTP URLs I made a mistake in calling the method on infoLink and I only called it in the Modal component and not in Cart. I think this should be fixed at the next PR.
@ArunJose I added your suggestions and fixed the issues you mentioned. Let me know if you still see any issues
@willnwhite and I have fixed the issue with absent data and how to handle it in frontend during our pair programming. Also @ArunJose mentionned an issue with unsecure image link URL. This PR resolve this too by changing all image URL from HTTP to HTTPS.