search

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Apply styling to Favorites page so it matches the other pages in the App #79

Closed snrelghgub closed 3 years ago

snrelghgub commented 3 years ago

Identified Issues in Favourites page (at time of writing this):

-Footer displaying higher than expected -Expected Text color not applied to name after log in
-Alignment issues with Card's 'more details' & 'delete' button in mobile & desktop view (this shall be fixed automatically with my PR #74) -'delete' button colors/icon do not meet minimum WCAG standards & UI/UX standards for graphical components & need be updated -'Favorites' header not centered & consistent with layout when displaying 'no favourites available' (Footer displaying higher than expected) -'Favorites' header not centered & consistent with layout when displaying favourited book (Footer displaying higher than expected) -All above mentioned issues need be rectified & tested to work in both mobile (especially for longer mobile screen devices) & in desktop view

snrelghgub commented 3 years ago

closing this issue as this issue was resolved in PR #80 after timely reviewal & approval by @ArunJose & further fixes based on valuable suggestions for improvements made by him, and before merging into your 'development' branch.