chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/
GNU General Public License v3.0
1 stars 1 forks source link

Styling Favorites page so it matches other pages in app #80

Closed snrelghgub closed 3 years ago

snrelghgub commented 3 years ago

Changes include:

ArunJose commented 3 years ago

It appears some of the main styles are still not applied in favorites page. Here's the same book in search page and favorite page.

image

Alignment is a bit off in favorites page.

snrelghgub commented 3 years ago

@ArunJose thanks for reviewing & reporting this vertical alignment issue, I'll fix it ASAP & before I merge changes. I thought you'd be interested to know that although I initially decided to remove the Footer from the Favorites page until thankfully it finally clicked to me that the grid layout I set out in SCSS file would automatically align any four distinct components rendered by the app in their generated order.

<div className='App'>
Section 1: <div></div> //any component1
Section 2: <div></div> //any component2
Section 3: <div></div> //any component3
Section 4: <div></div> //any component4
</div>

As long as there are four distinct components rendered for the 4 predefined CSS grid-template-areas & their set fractional height, these will automatically be applied to those 4 main wrappers to ensure they display where expected. Something I'd thought I'd share as I'm sure you'd be interested to know or maybe you might run into a similar issue again in the future 👍

snrelghgub commented 3 years ago

Alignment is a bit off in favorites page

Thanks for reporting this, I'll look into & fix this one as well 👍