Unable to view favourites after logging in (in mobile view)

chingu-voyages / v24-geckos-team-02

Books Plus | Voyage-24 | https://chingu.io/

GNU General Public License v3.0

1 stars 1 forks source link

Unable to view favourites after logging in (in mobile view) #81

Closed snrelghgub closed 3 years ago

snrelghgub commented 3 years ago

Describe the bug Unable to view favorites after successfully logging in (in mobile view)

To Reproduce Steps to reproduce the behavior:

ensure you are not logged in
go in mobile view where hamburger menu is displayed
log in via hamburger menu
attempt to access favourites after successful log in
message displayed is: Please log in to see your favorites

Expected behavior User shall be able to view & access their favourites successfully from a mobile device in mobile view

ArunJose commented 3 years ago

This is because no props are passed to <HamburgerMenu /> in Navbar.jsx. It should be <HamburgerMenu {...props} />. Setter for authtoken is being passed in as props which is needed for <Authentication /> inside <HamburgerMenu />

snrelghgub commented 3 years ago

hello @ArunJose thanks for taking the time for looking into this issue & reporting the root cause. I'll fix this issue in my current PR #80 instead of creating another PR to resolve this issue & due to our time constraint 👍

snrelghgub commented 3 years ago

closing this as this issue was resolved in a commit via PR #80 & due to time constraints. Thanks again @ArunJose for your promptly coordination & assistance on this issue.