chingu-voyages / v33-toucans-team-03

An online development environment | Voyage-33 | https://chingu.io/ | Twitter: https://twitter.com/ChinguCollabs
https://chingu-pen.herokuapp.com/
1 stars 2 forks source link

All div tag in App.js can be taken to its respective component file #17

Closed Guneetsinghtuli closed 3 years ago

Guneetsinghtuli commented 3 years ago

Describe the problem Currently in App.js Editor component is inside the div's which have some CSS, this reduces the readability of the code.

Expected behavior All the div should be inside their component file and only the component should be imported onto the App.js file

To Reproduce Steps to reproduce the behavior:

  1. Go to App.js file and remove the div tag from there
  2. Add all those div to the Component file
  3. Changes in CSS files should be made accordingly

Screenshot Screenshot 2021-09-16 at 9 10 05 PM

ArjunHollaM commented 3 years ago

I will work on this. Should I create a new component for this?

Guneetsinghtuli commented 3 years ago

@ArjunHollaM Add all these Div in the Editor component itself and make the changes in CSS files accordingly

ArjunHollaM commented 3 years ago

Not a good Idea