Button - Githubissues

chingu-voyages / v39-bears-team-16

3 stars 0 forks source link

Button #134

Closed RDiMag closed 2 years ago

RDiMag commented 2 years ago

Closes #126

This ticket adds Pill Label Primary and Secondary Styling, Primary button styling, and the icon avatar with user initial.

netlify[bot] commented 2 years ago

Deploy Preview for sailacademy ready!

Name	Link
Latest commit	411dd657bd223a7b62d2c88bd8204465cb0fa70e
Latest deploy log	https://app.netlify.com/sites/sailacademy/deploys/62f1585eb82ed800094d0a71
Deploy Preview	https://deploy-preview-134--sailacademy.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

RDiMag commented 2 years ago

errors_pill_label

jpatrici commented 2 years ago

can you also please copy paste what you wrote in the description to be in the comment section of the PR instead? The description of the PR should have the ticket number and some explanation about the PR/ticket

RDiMag commented 2 years ago

Early comments below for reference:

Hi @jpatrici,

I'm not sure where I need to go to ensure the primary/secondary styling does not pull in the borders, and to make the font color black for the secondary styling.

I am also seeing some errors. At least one error can be ignored, it is only showing up because I manually entered text in the Pill Label divs so I could check the styling of the text.

RDiMag commented 2 years ago

I have pushed this for troubleshooting assistance. I'm going to upload the errors which I'm getting. I can't fix the Netlify error without deviating from the example code above.

RDiMag commented 2 years ago

pill-label-errors