search

chingu-voyages / v39-bears-team-16

3 stars 0 forks source link

Edit Class Modal layout changes #144

Closed Marcellia closed 1 year ago

Marcellia commented 1 year ago

This closes #121

This issue includes

netlify[bot] commented 1 year ago

Deploy Preview for sailacademy failed.

Name Link
Latest commit 3f04a3ccba1f944f4ab99106c1584fec18cf7af7
Latest deploy log https://app.netlify.com/sites/sailacademy/deploys/6325f183abb8b60008b46253
jpatrici commented 1 year ago

looks like the class accordion is back to the old styling

Screen Shot 2022-09-09 at 10 37 25 AM

new styling in main branch:

Screen Shot 2022-09-09 at 10 38 54 AM
jpatrici commented 1 year ago

Also, referring back to Figma, I think some things in the classwork modal needs to be updated:

  1. back to Syllabus text color should be black
  2. If possible, add padding bottom below the modal button
  3. Classwork instead of Class Work
  4. Add New Classwork instead of New Class Work
  5. Submit button should be the SecondaryButton, and Save instead of Submit 
    <SecondaryButton type="submit" form="EditClassForm">
 Save
</SecondaryButton>
Screen Shot 2022-09-09 at 10 42 28 AM

Figma:

Screen Shot 2022-09-09 at 10 44 02 AM

Note: I do think it's a bit of an overkill to have the close button and the back button 🤔 i'll ask Carla about this. For now it's okay to have them both. I think Figma has it as its own form page, while we have it as a full screen modal, which is fine, but it will make more sense to have the modal without the back button.

jpatrici commented 1 year ago

hmm seems like we have a double scroll problem 🤔

Screen Shot 2022-09-15 at 4 52 57 PM
Marcellia commented 1 year ago

hmm seems like we have a double scroll problem 🤔 Screen Shot 2022-09-15 at 4 52 57 PM

Interesting I don't have that on my end.

Marcellia commented 1 year ago

Thanks for fixing the layout 🙂 I found something interesting: after I hit save on the modal, the classworks did appear in the accordion, but when i clicked edit class again, no classworks there unless i refresh the page.

Otherwise, it looks good 👍

This was a head scratcher! but resolved it :)

Marcellia commented 1 year ago

apparently upgrading the react hook form causes the TS error. I see all the TS errors are around errors.classworks saying that it could be undefined. I tried reading their release log, but the only one that seems to be related is the one they said they fix errors to accept any type 🤔

That's so weird! Mine Compiled successfully, & webpack compilation did not indicate any errors. Let me check that out.