chingu-voyages / v39-bears-team-16

3 stars 0 forks source link

draft for review and troubleshooting #48

Closed RDiMag closed 2 years ago

RDiMag commented 2 years ago

I can make some style changes, but I can't seem to target the divs like I was expecting to.

netlify[bot] commented 2 years ago

Deploy Preview for 100devstracker ready!

Name Link
Latest commit b03eca46ed012718f81a4c90c3784ca2b1bc3625
Latest deploy log https://app.netlify.com/sites/100devstracker/deploys/628414be9c7ae9000925ecb2
Deploy Preview https://deploy-preview-48--100devstracker.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

RDiMag commented 2 years ago

@Danneytrieu Would you give this a look? Please feel free to make any changes needed so this can be completed, or let me know how to proceed. I left comments within the file where I am not sure how to fix the alignment of items.

RDiMag commented 2 years ago

@jpatrici I'm not sure how to resolve the Netlify issues. I don't really have much familiarity with Netlify so I will need some guidance if you have time!

jpatrici commented 2 years ago

@jpatrici I'm not sure how to resolve the Netlify issues. I don't really have much familiarity with Netlify so I will need some guidance if you have time!

so if you click on Details:

Screen Shot 2022-05-11 at 10 11 50 PM

you'll see the Deploy logs and where it failed

Screen Shot 2022-05-11 at 10 12 53 PM

If you run your app locally with npm start, you should be able to see the same errors/warnings in the terminal i believe. So these warnings should be fixed first, and it should be all green before netlify can deploy successfully

RDiMag commented 2 years ago

Hi @jpatrici,

I'm unable to get my earlier styling to work in this new branch. I tested using an earlier version of the branch and made the changes within the AdminNavbar.tsx file to include the new cohorts routing function. The buttons/Active style show up as expected there. But in this current commit, it seems like only the items in the UserInfoContainer section are being rendered.

See attached image - on the left is the earlier branch with isCohortPage function and right is the new branch navbar_comparison .

jpatrici commented 2 years ago

Hi @jpatrici,

I'm unable to get my earlier styling to work in this new branch. I tested using an earlier version of the branch and made the changes within the AdminNavbar.tsx file to include the new cohorts routing function. The buttons/Active style show up as expected there. But in this current commit, it seems like only the items in the UserInfoContainer section are being rendered.

See attached image - on the left is the earlier branch with isCohortPage function and right is the new branch navbar_comparison .

@RDiMag that's because we decided to not show the menu on the cohorts page. I don't remember if you're in the meeting or not when we discussed/decided on the navbar 🤔 if not, pardon me then, I should've explained! So we decided that we want the nav bar to show the dashboard and class menu items only when the user have already picked a cohort. So here's the flow

  1. User signs in
  2. User gets redirected to /admin/cohorts page. There should be only the user profile and logout in this page
  3. User picked a cohort and then they get redirected to /admin/cohorts/<cohortId>/dashboard where they can see the navbar with Home, Dashboard, Update Class and Logout menu items.
Screen Shot 2022-05-13 at 10 01 01 PM

I've pushed an update in the PR, so that the logout button will always show in the navbar. Don't forget to pull first from this PR (do git pull --rebase) Note: I think you'll need to fix the styling so that the UserInfoContainer will have a fixed position and not move down when the menu items are missing.

RDiMag commented 2 years ago

I think this is ready for review so I can merge it. I haven't added the edit button yet, since I wasn't sure if it would be a recurring component or not.