Closed RDiMag closed 2 years ago
Name | Link |
---|---|
Latest commit | b03eca46ed012718f81a4c90c3784ca2b1bc3625 |
Latest deploy log | https://app.netlify.com/sites/100devstracker/deploys/628414be9c7ae9000925ecb2 |
Deploy Preview | https://deploy-preview-48--100devstracker.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@Danneytrieu Would you give this a look? Please feel free to make any changes needed so this can be completed, or let me know how to proceed. I left comments within the file where I am not sure how to fix the alignment of items.
@jpatrici I'm not sure how to resolve the Netlify issues. I don't really have much familiarity with Netlify so I will need some guidance if you have time!
@jpatrici I'm not sure how to resolve the Netlify issues. I don't really have much familiarity with Netlify so I will need some guidance if you have time!
so if you click on Details
:
you'll see the Deploy logs and where it failed
If you run your app locally with npm start
, you should be able to see the same errors/warnings in the terminal i believe. So these warnings should be fixed first, and it should be all green before netlify can deploy successfully
Hi @jpatrici,
I'm unable to get my earlier styling to work in this new branch. I tested using an earlier version of the branch and made the changes within the AdminNavbar.tsx file to include the new cohorts routing function. The buttons/Active style show up as expected there. But in this current commit, it seems like only the items in the UserInfoContainer section are being rendered.
See attached image - on the left is the earlier branch with isCohortPage function and right is the new branch .
Hi @jpatrici,
I'm unable to get my earlier styling to work in this new branch. I tested using an earlier version of the branch and made the changes within the AdminNavbar.tsx file to include the new cohorts routing function. The buttons/Active style show up as expected there. But in this current commit, it seems like only the items in the UserInfoContainer section are being rendered.
See attached image - on the left is the earlier branch with isCohortPage function and right is the new branch .
@RDiMag that's because we decided to not show the menu on the cohorts page. I don't remember if you're in the meeting or not when we discussed/decided on the navbar 🤔 if not, pardon me then, I should've explained! So we decided that we want the nav bar to show the dashboard and class menu items only when the user have already picked a cohort. So here's the flow
/admin/cohorts
page. There should be only the user profile and logout in this page/admin/cohorts/<cohortId>/dashboard
where they can see the navbar with Home
, Dashboard
, Update Class
and Logout
menu items.I've pushed an update in the PR, so that the logout button will always show in the navbar. Don't forget to pull first from this PR (do git pull --rebase
)
Note: I think you'll need to fix the styling so that the UserInfoContainer
will have a fixed position and not move down when the menu items are missing.
I think this is ready for review so I can merge it. I haven't added the edit button yet, since I wasn't sure if it would be a recurring component or not.
I can make some style changes, but I can't seem to target the divs like I was expecting to.