search

chingu-voyages / v39-geckos-team-07

Chingu Voyage 39 - Geckos Team 07
2 stars 2 forks source link

style(markup) mainpage #41

Closed sosososoyoen closed 2 years ago

sosososoyoen commented 2 years ago
  1. markup main page(searchbar,theme recipe, lookup recipe)
  2. add local font (1)
  3. fix footer style screencapture-localhost-3000-2022-04-24-02_26_20
quangthandev commented 2 years ago

excellent!

quangthandev commented 2 years ago

Just a small issue: there existed a "public" folder in root directory, as you created a new "public" folder in "pages", which is confusing

sosososoyoen commented 2 years ago

image I moved the "public" folder into the "page" folder Is this OK?

quangthandev commented 2 years ago

I don't know if your implementation is a good practice or not, but Next.js recommend to keep the "public" folder in root folder for static file serving. So in my opinion, we should keep the "public" folder at root directory and serve the images as static file. As a result, we don't need to use next-images library.

quangthandev commented 2 years ago

Like this:

image

sosososoyoen commented 2 years ago

thank you!!! i'll fix it and merge!