Nav

[jameswonlee]

Basic functionality of navbar including logo (home), hamburger menu (open and close), navigation in hamburger menu options, and shopping cart (open and close).

[jameswonlee]

Oh yeah. It looks like sticky works better than fixed. I made the changes and created a new PR. Thanks!

On Oct 25, 2023, at 7:34 PM, Sean Paulson @.***> wrote:

Looks like the container div in the Navbar.tsx component does need to be position sticky. Try going to the /profile page and try it with sticky and fixed and let me know what you think.

— Reply to this email directly, view it on GitHub https://github.com/chingu-voyages/v46-tier3-team-37/pull/45#issuecomment-1780321953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZ3CPUPXINONJITIRT6P3LYBHDZVAVCNFSM6AAAAAA6QC7FU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGMZDCOJVGM. You are receiving this because you authored the thread.

[jameswonlee]

Thanks! I’m not sure if you saw but I closed PR #45. I created a new PR # 47. I wasn’t sure if that was the correct way of doing things, or if I should have just left PR #45 open with the changes I made to the CSS positioning.

On Oct 26, 2023, at 8:05 AM, Sean Paulson @.***> wrote:

@SeanPaulson commented on this pull request.

Looks good!

In components/NavBar/navbar.tsx https://github.com/chingu-voyages/v46-tier3-team-37/pull/45#discussion_r1372505482:

• }
• useEffect(() => {
• if (!showToolBox) return;
• document.addEventListener('click', closeToolBox);
• return () => document.removeEventListener("click", closeToolBox);
• }, [showToolBox]);
• useEffect(() => {
• if (!showMenu) return;
• document.addEventListener('click', closeMenu);
• return () => document.removeEventListener("click", closeMenu);
• }, [showMenu]);
• return (
• Looks like you will need to change display to sticky on this container. Go to profile page and try it with fixed and sticky and let me know what you think.

— Reply to this email directly, view it on GitHub https://github.com/chingu-voyages/v46-tier3-team-37/pull/45#pullrequestreview-1698624440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZ3CPW4YKLOIS36NFCSGALYBJ335AVCNFSM6AAAAAA6QC7FU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJYGYZDINBUGA. You are receiving this because you modified the open/close state.