chingu-voyages / v48-tier1-team-04

Chingu Raptors present: Dinosauria | Voyage-48 | https://chingu.io/ | Twitter: https://twitter.com/ChinguCollabs
https://v48-tier1-team-04.netlify.app/
2 stars 1 forks source link

feature: all dinosaurs rendered with pagination #100

Closed mnichols08 closed 7 months ago

mnichols08 commented 7 months ago

im working quickly I apologize for so many changes at once and not the towards refactoring the code either =(

This brings back the popup and the display index and the chart is rendered now as well

We still need search for this to be "MVP" but other than a few css tweaks it has functionality

We need to call the displayDinosaur in a few places still for call to actions but we can discuss later what is left

I am utilizing the code that was written before by injecting the necessary html into the places its rendered.

I did have to move where we called the functions created previously from the main.js file into the mainComponent.js file

Now next task is to refactor this project.

I've come to realize that it's harder to simply import the scss into js components, and keep the variables and mixins, etc that we've created. So for that I will just emplore you to dive into the scss to find out where the styles are coming from. I Insist that its easier to read/manage than plain css if we had this many styles.

It's hard but its not impossible and ill spend a few hours cleaning up our codebase.

This is what I meant about the code being harder to maintain if we didn't follow any architecture ;)

netlify[bot] commented 7 months ago

Deploy Preview for v48-tier1-team-04-dev ready!

Name Link
Latest commit d50c672450e5c03407d76d878d0ede81c6061536
Latest deploy log https://app.netlify.com/sites/v48-tier1-team-04-dev/deploys/6616df9df9a050000870c32f
Deploy Preview https://deploy-preview-100--v48-tier1-team-04-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.