search

chingu-voyages / v48-tier1-team-04

Chingu Raptors present: Dinosauria | Voyage-48 | https://chingu.io/ | Twitter: https://twitter.com/ChinguCollabs
https://v48-tier1-team-04.netlify.app/
2 stars 1 forks source link

Added chart.js/jo #82

Closed JOSIK95 closed 7 months ago

JOSIK95 commented 7 months ago

attempted to add chart.js and to main.js within Vite directory

netlify[bot] commented 7 months ago

Deploy Preview for v48-tier1-team-04-dev ready!

Name Link
Latest commit e6b04d958ddc0959354725d731cb1d1c6953258a
Latest deploy log https://app.netlify.com/sites/v48-tier1-team-04-dev/deploys/660c8dc914fc370008e16cca
Deploy Preview https://deploy-preview-82--v48-tier1-team-04-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vinccodes commented 7 months ago

Ok, please someone tell if I'm wrong. But I understand that you have to include the node_modules carpet for git, the only file you need is package.json Because once you clone the repository in your computer, you only have to run: npm install that detects the package.json and installs all the neccesary things. And other thing is Vite. I understand that vite creates a folder structure. For Vite the "public" directory is where your project will be compilled and shouldn't have any code made by humans.....ok that sounded weird. Any code that we made now has to be outside the public carpet.

And also there are 2 public directories, I don't know if that will be an issue later. One inside the vitejs.

But well the it kinda seems to work remotetly so I don't know what the others think

Correct @sebastiandlq, we should not track the the node_modules/ folder and add it to the .gitignore. It looks like @JOSIK95 created a new Vitejs vanilla project inside the chingu-raptors/public folder via npm create vite@latest command