search

chingu-voyages / v8-geckos-team-07

Habit-Tracker | Voyage-8 | https://chingu.io/
https://habit-tracker-gecko.herokuapp.com/
4 stars 4 forks source link

📝: Move NewHabit.js/.css functionality to parent level (Dashboard.js) #66

Closed paulywill closed 5 years ago

paulywill commented 5 years ago

Task Description

Move the functionality from NewHabit.js/.css to parent level (Dashboard.js/.css)

Function

This will allow other forms (ie CheckIn #13 ) can inherit the same functionality and styling.

This includes the modal function @pjconnolly12 (@SaraSweetie ) are working on. -> #60

Feature

11 : New Habit

Do not forget to set Epic, Milestone, and Estimate (1 = half workday)!

pjconnolly12 commented 5 years ago

I just want to confirm, is this saying move the form to the Dashboard component? Personally I don't think that is the best in terms of React best practices. We want to try and keep components separate. We will be able to pass functionality through state and props. Let me know if anyone disagrees with this.

paulywill commented 5 years ago

@SaraSweetie ?

From our team meeting I thought the NewHabit component stays put... but some of the functions should be at the parent level and passed down ?

paulywill commented 5 years ago

71 contains some of the work for this work item.

Still in QA & Review.

SaraSweetie commented 5 years ago

I think we need to move the functionality to App.js? That way we can use the state/props for both components (check-in.js and NewHabit.js)

We need to think through how the users are going to are going to access the NewHabit.js form. The check-in.js form is going to be accessed from Dashboard.js.