chingu-voyages / v8-geckos-team-07

Habit-Tracker | Voyage-8 | https://chingu.io/
https://habit-tracker-gecko.herokuapp.com/
4 stars 4 forks source link

🔨🐛 - adding 404 page not found component #72

Closed paulywill closed 5 years ago

paulywill commented 5 years ago

Ugly but functional 404 page not found #49

image

paulywill commented 5 years ago
  • Does this page appear with a header? Maybe import the <Header> component? If you do that I would suggest to make your <h1> into an <h2>, for accessibility.
  • Also you can delete the <h2>404 Error</h2> <p>App.js is the defualt page.</p> Since we have an error page that is no longer needed.

@SaraSweetie Changed to h2; removed "404 error" from App.js. Even made edit in alt=, removing the word "image" to resolve console warning.

I suspect some CSS is required for

image

SaraSweetie commented 5 years ago
paulywill commented 5 years ago

To be honest I sort of like the original error message :/

image

I was trying to be cute with our team's name.... might combine the style of the two

paulywill commented 5 years ago

how's this?

image