search

chingu-x / chingu-dashboard

https://chingu-dashboard.vercel.app
GNU General Public License v3.0
9 stars 2 forks source link

Discord Id not showing up in the directory #202

Closed cherylli closed 5 days ago

cherylli commented 3 weeks ago

Describe the bug Discord id not showing up in the directory

To Reproduce Bug Steps to reproduce the bug:

  1. Go to My Voyage
  2. Go to directory

Expected behavior It should show up if they have their discord account connected via oauth. currently they don't so the display is correct. However, we will need to fix the backend to return users discord id in the team info endpoint (it is now stored in another table - userOAuthProfile)

Screenshots image

Additional context Add any other context about the problem here.

--------------- End of User Report: DO NOT MODIFY ITEMS BELOW THIS LINE ---------------

GitHub Issue No. / ID

Team Task Here will be added Team declaration by Team Leads.

Development start date Date when dev team start fixing a bug

Development end date Date when dev team complete fixing a bug

BugFix Deploy Date Date when BugFix is deployed, and Bug Issue is closed

PO Comment Here will be PO team add a comment.

cherylli commented 3 weeks ago

So I realized we have already updated the api response last week - but I'll need to also update the swagger sample response

this is how it looks like now, so frontend needs to update how it gets the discordID from the response. I will seed the dev database to populate jessica's discord oauth image

Dan-Y-Ko commented 3 weeks ago

I'm guessing we use the providerUsername?

I didn't look at Swagger yet, I'm sure that will answer my question lol

cherylli commented 3 weeks ago

yeah it would be something like oauthProfile.find(provider.name==="discord").providerUsername

jdmedlock commented 2 weeks ago

DO NOT MODIFY/DELETE THIS COMMENT Project task ID: 86b1v4mjw