chingu-x / feedback

Chingu Feedback
0 stars 0 forks source link

New User Onboarding survey #46

Closed Spell2az closed 6 years ago

Spell2az commented 6 years ago

from console: manifest.json:1 Manifest: Line: 1, column: 1, Unexpected token. DynamicFormContainer.jsx:204 Missing hiddenData for: timezone (anonymous) @ DynamicFormContainer.jsx:204

Unable to proceed after form has been filled out. Button is still showing incomplete.

tropicalchancer commented 6 years ago

Hi @Spell2az,

Thanks for reaching out!

Could you possibly send some screenshots so we can better navigate what the problem is?

Spell2az commented 6 years ago

[cid:image003.png@01D47687.34C2EF40] I hope I didn’t miss anything.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10


From: Chance notifications@github.com Sent: Wednesday, November 7, 2018 10:42:57 AM To: chingu-x/feedback Cc: Spell2az; Mention Subject: Re: [chingu-x/feedback] New User Onboarding survey (#46)

Hi @Spell2azhttps://github.com/Spell2az,

Thanks for reaching out!

Could you possibly send some screenshots so we can better navigate what the problem is?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/chingu-x/feedback/issues/46#issuecomment-436582023, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYlr76Cn85vsbOzymKk4yjgKzBJ3Dt7lks5usrkxgaJpZM4YSGxb.

tropicalchancer commented 6 years ago

Hey @Spell2az,

No worries, we just launched so there's bound to be bugs - and if you missed something, that is our fault - it means we need to fix something so that members can't miss things. 😃

Also @Spell2az can you try to resend that image? It doesn't seem to have went through.

Spell2az commented 6 years ago

If it wont go through, let me know I will upload it somewhere and send you link. [cid:image001.png@01D4768B.E4796640] Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10


From: Chance notifications@github.com Sent: Wednesday, November 7, 2018 11:10:41 AM To: chingu-x/feedback Cc: Spell2az; Mention Subject: Re: [chingu-x/feedback] New User Onboarding survey (#46)

Hey @Spell2azhttps://github.com/Spell2az,

No worries, we just launched so there's bound to be bugs - and if you missed something, that is our fault - it means we need to fix something so that members can't miss things. 😃

Also @Spell2azhttps://github.com/Spell2az can you try to resend that image? It doesn't seem to have went through.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/chingu-x/feedback/issues/46#issuecomment-436589402, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYlr75ooV6fEFotZbqy-otxPDl-Mc6XGks5usr-xgaJpZM4YSGxb.

the-vampiire commented 6 years ago

anyone else still having this issue?

i am not able to reproduce it. suggestions to try (if you havent already):

if these steps work for you or you find a different way of fixing it post it so others can see. if the problem persists can you copy over any errors / warnings / logs from the dev tools so i can try to debug it

Spell2az commented 6 years ago

DynamicFormContainer.jsx:204 Missing hiddenData for: timezone
(anonymous) @ DynamicFormContainer.jsx:204 (anonymous) @ DynamicFormContainer.jsx:181 value @ DynamicFormContainer.jsx:41 vr @ react-dom.production.min.js:227 hr @ react-dom.production.min.js:218 pr @ react-dom.production.min.js:217 sr @ react-dom.production.min.js:214 nr @ react-dom.production.min.js:212 enqueueForceUpdate @ react-dom.production.min.js:134 (anonymous) @ react.production.min.js:13 (anonymous) @ react-apollo.browser.umd.js:389 next @ react-apollo.browser.umd.js:371 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ ObservableQuery.js:337 next @ ObservableQuery.js:337 (anonymous) @ QueryManager.js:407 (anonymous) @ QueryManager.js:698 (anonymous) @ QueryManager.js:697 (anonymous) @ QueryManager.js:692 next @ QueryManager.js:749 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ dedupLink.js:60 next @ dedupLink.js:60 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 next @ index.js:41 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ httpLink.js:95 Promise.then (async) (anonymous) @ httpLink.js:93 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ index.js:96 Promise.then (async) (anonymous) @ index.js:95 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ index.js:23 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ dedupLink.js:55 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ QueryManager.js:729 (anonymous) @ QueryManager.js:727 (anonymous) @ QueryManager.js:260 (anonymous) @ QueryManager.js:585 (anonymous) @ ObservableQuery.js:344 (anonymous) @ ObservableQuery.js:312 (anonymous) @ ObservableQuery.js:43 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ react-apollo.browser.umd.js:363 (anonymous) @ react-apollo.browser.umd.js:466 vr @ react-dom.production.min.js:227 hr @ react-dom.production.min.js:218 pr @ react-dom.production.min.js:217 sr @ react-dom.production.min.js:214 nr @ react-dom.production.min.js:212 enqueueForceUpdate @ react-dom.production.min.js:134 (anonymous) @ react.production.min.js:13 (anonymous) @ react-apollo.browser.umd.js:389 next @ react-apollo.browser.umd.js:371 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ ObservableQuery.js:337 next @ ObservableQuery.js:337 (anonymous) @ QueryManager.js:407 (anonymous) @ QueryManager.js:698 (anonymous) @ QueryManager.js:697 (anonymous) @ QueryManager.js:692 next @ QueryManager.js:749 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ dedupLink.js:60 next @ dedupLink.js:60 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 next @ index.js:41 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 p @ Observable.js:130 d @ Observable.js:165 value @ Observable.js:219 (anonymous) @ httpLink.js:95 Promise.then (async) (anonymous) @ httpLink.js:93 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ index.js:96 Promise.then (async) (anonymous) @ index.js:95 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ index.js:23 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ dedupLink.js:55 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ QueryManager.js:729 (anonymous) @ QueryManager.js:727 (anonymous) @ QueryManager.js:260 (anonymous) @ QueryManager.js:585 (anonymous) @ ObservableQuery.js:344 (anonymous) @ ObservableQuery.js:312 (anonymous) @ ObservableQuery.js:43 e @ Observable.js:183 value @ Observable.js:262 (anonymous) @ react-apollo.browser.umd.js:363 (anonymous) @ react-apollo.browser.umd.js:466 vr @ react-dom.production.min.js:227 hr @ react-dom.production.min.js:218 pr @ react-dom.production.min.js:217 sr @ react-dom.production.min.js:214 nr @ react-dom.production.min.js:212 enqueueSetState @ react-dom.production.min.js:133 (anonymous) @ react.production.min.js:13 (anonymous) @ Router.js:70 n @ createTransitionManager.js:46 (anonymous) @ createTransitionManager.js:65 notifyListeners @ createTransitionManager.js:64 O @ createBrowserHistory.js:78 (anonymous) @ createBrowserHistory.js:169 n @ createTransitionManager.js:36 P @ createBrowserHistory.js:149 (anonymous) @ index.jsx:44 r @ runtime.js:62 (anonymous) @ runtime.js:296 (anonymous) @ runtime.js:114 r @ main.f6ffbb03.js:79717 (anonymous) @ main.f6ffbb03.js:79717 Promise.then (async) r @ main.f6ffbb03.js:79717 (anonymous) @ main.f6ffbb03.js:79717 (anonymous) @ main.f6ffbb03.js:79717 e @ main.f6ffbb03.js:79722 vr @ react-dom.production.min.js:227 hr @ react-dom.production.min.js:218 pr @ react-dom.production.min.js:217 sr @ react-dom.production.min.js:214 nr @ react-dom.production.min.js:212 Er @ react-dom.production.min.js:234 wr @ react-dom.production.min.js:234 (anonymous) @ react-dom.production.min.js:242 (anonymous) @ react-dom.production.min.js:245 br @ react-dom.production.min.js:231 Ir @ react-dom.production.min.js:245 render @ react-dom.production.min.js:247 (anonymous) @ index.js:35 t @ bootstrap 94b32ed995a6723230aa:19 (anonymous) @ main.f6ffbb03.js:45947 t @ bootstrap 94b32ed995a6723230aa:19 (anonymous) @ bootstrap 94b32ed995a6723230aa:62 (anonymous) @ bootstrap 94b32ed995a6723230aa:62

This is what I get besides this one Manifest: Line: 1, column: 1, Unexpected token.

I did try your suggestions on Firefox and also Edge but it didn't work.

the-vampiire commented 6 years ago

This is the logs after you tried the above steps?

Sent with GitHawk

the-vampiire commented 6 years ago

Are you available tomorrow? We can screen share and debug it together. I’m really curious about what the cause is. It seems to only be affecting you and one other.

Sent with GitHawk

Spell2az commented 6 years ago

Sure you can find me on slack in voyage 6 channel.

Get Outlook for Androidhttps://aka.ms/ghei36


From: Vamp notifications@github.com Sent: Thursday, November 8, 2018 2:11:17 AM To: chingu-x/feedback Cc: Spell2az; Mention Subject: Re: [chingu-x/feedback] New User Onboarding survey (#46)

Are you available tomorrow? We can screen share and debug it together. I’m r ally curious about hay the cause is. It seems to only be affecting you and one other.

Sent with GitHawkhttp://githawk.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/chingu-x/feedback/issues/46#issuecomment-436848138, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYlr73UQ5gdYj5Z9Yixll_S0m6wEE-PIks5us5LFgaJpZM4YSGxb.

jenbird commented 6 years ago

Cleared local storage etc as advised above then tested again on Chrome. Form data is there but shows as false/field_errors probably due to timezone issue mentioned before. (test@gmail.com used so I could hide my email but using my email address doesn't work anyway) Class on submit button still shows as .form-btn--disabled

screenshot 2018-11-08 at 15 12 41
jenbird commented 6 years ago

is it this... components/index.jsx line 15 remove double curly brackets from timezone variable? hiddenData={timezone} thanks

the-vampiire commented 6 years ago

HiddenData (as ominous as it may sound lol) is just an object with values for input type “hidden”. So it needs the double curlies (outer for passing a non string prop, inner for representing the hiddenData Object

Sent with GitHawk

the-vampiire commented 6 years ago

sorry for the delay i was at the vet. working on a solution now. seems to be that your timezone offsets arent being picked up. the function is compatible with all modern browsers so im not sure what the reason is.

in any case we are moving the timezone question (used in team formation - for the record) to your (private, /profile) page. will let you guys know when it is up.

the-vampiire commented 6 years ago

@Spell2az @jennifersmithuk hey the changes are live. log out, clear local storage, then log back in and you should be able to fill out and submit now!

let me know if there are still any problems or if its ok to mark this issue as solved

Spell2az commented 6 years ago

Sorted. Thank you. Could you please describe what was the problem and how did you solve it as it only affected couple of people.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10


From: Vamp notifications@github.com Sent: Friday, November 9, 2018 7:32:34 PM To: chingu-x/feedback Cc: Spell2az; Mention Subject: Re: [chingu-x/feedback] New User Onboarding survey (#46)

@Spell2azhttps://github.com/Spell2az @jennifersmithukhttps://github.com/jennifersmithuk hey the changes are live. log out, clear local storage, then log back in and you should be able to fill out and submit now!

let me know if there are still any problems or if its ok to mark this issue as solved

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/chingu-x/feedback/issues/46#issuecomment-437470224, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYlr79iv6sMN9nlWovuGlqXxo6QSENIVks5utdhSgaJpZM4YSGxb.

jenbird commented 6 years ago

@the-vampiire brilliant, thank you. have submitted form now. would also be interested in problem/solution please.

the-vampiire commented 6 years ago

I’m wondering if due to a browser privacy setting time zone offset isn’t being calculated. You’d think it would show null though.

The fix here was more of an upgrade. Got rid of implicit time zones altogether. The original intention was to calculate it automatically to prevent user error.

Now it’s a selectable that we will include in the pre voyage update section. We’ll see if there are a lot of errors but I think most of us know our time zones so it shouldn’t be a problem.

I never found d out the cause because I didn’t want to burden you guys with debugging. Figured you’d be happier with a solution than a debugging process.

But if you are as curious as I am. Can you try running

const d = new Date(); d.getTimezoneOffset();

In your browser dev tools. Let me know what the result is?

Sent with GitHawk

jenbird commented 6 years ago

@the-vampiire thanks for sorting issue and explaining too. I did this to try and debug before my last comment. Have just tried again now and get the same result which is 0 (I'm GMT 0) so it is, and was, being calculated. ¯_(ツ)_/¯ No idea why timezone was showing as an empty string and throwing a field error. Can't recreate any more as I've now completed form since fix but if there's anything I can do to help let me know.

jenbird commented 6 years ago

@the-vampiire just took look through commits out of curiosity. As getTimezoneOffset() returns a number rather than the Date object is this what is causing the issue as DynamicForm.propTypes says hiddenData: PropTypes.object ?

the-vampiire commented 6 years ago

@jennifersmithuk love the curiosity! actually the prop type is correct. hiddenData is an object of the form

hiddenData = { field_name: 'value', field_name: number, ... }

it lets you pass in any number of field_name/value pairs to provide data for hidden input types.

its interesting that your value is 0. somehow that must have been translated into a falsey string equivalent (''). its going to bug me but ive got too much else to work on to dig much further right now.

if we find that user selected timezones are a problem and we return to implicit timezones ill definitely figure it out and let you know. thanks again for the heads up