search

chinhodado / persona5_calculator

A tool to help calculate fusions in Persona 5.
https://chinhodado.github.io/persona5_calculator/
Apache License 2.0
326 stars 133 forks source link

Change DLC settings from opt-out to opt-in. #35

Closed Gredelston closed 5 years ago

Gredelston commented 5 years ago

Hi @chinhodado -- I believe my colleagues reached out to you about this change. We're using your calculator to support a Persona-related project we're running right now, and we've found that people find opt-in DLC more intuitive. I've tested the change on my local system.

For some reason it's showing commits d7dc11c, 1f87f62, and 449a9fd as part of this PR, even though they were merged in on 11/27/2018 as a91657b.

chinhodado commented 5 years ago

Can you fix up the pull request so that it only contains the relevant change (the 61acb63 commit)?

Gredelston commented 5 years ago

Yes, will do tomorrow.

On Wed, Jan 9, 2019, 5:30 PM Trung Do <notifications@github.com wrote:

Can you fix up the pull request so that it only contains the relevant change (the 61acb63 https://github.com/chinhodado/persona5_calculator/commit/61acb6332aadefd2e0d8c62fdbf02b71679b5ee5 commit)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chinhodado/persona5_calculator/pull/35#issuecomment-452934448, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWitSzfawBxI6ulCQMLcbxukg5Jk7VGks5vBpV6gaJpZM4Z2147 .

Gredelston commented 5 years ago

@chinhodado The diff now only contains the relevant change. Let me know what you think.

Cheers, Greg

chinhodado commented 5 years ago

Thanks, merged