chinhodado / persona5_calculator

A tool to help calculate fusions in Persona 5.
https://chinhodado.github.io/persona5_calculator/
Apache License 2.0
326 stars 133 forks source link

Add Inheritance and Mementos data to index and persona info #81

Closed a-calkins closed 1 year ago

a-calkins commented 1 year ago

This pull request adds a few enhancements and minor fixes:

Adds the Mementos locations for personas that can be found in Mementos/palaces. This add a column to the main index and allows for sorting by area. An icon that can be hovered over will show the floors it is available on. This column is hidden in the mobile version, so this info is also displayed at the top of the persona's info page. I did not show palace locations as this constitutes spoilers. Fixes #23

Alters some text to better match the in-game text, such as "weak" damage being changed to "light". In the case of Swift Strike, damage becomes "miniscule" in the Royal version since it was nerfed. "Akasha Arts" was also renamed to "Akashic Arts" in Royal, so this was altered as well. "Mithra" also became "Mitra", since he is Mitra in P5 despite being Mithra in other megaten entries. Fixes #80

Adds inheritance data and sorting by inheritance types. This appears as an additional "Inherits" column on desktop in the main index (hidden on mobile), as well as a table of inheritable skill types on the persona's info page. This table is split into two for mobile to follow suit with the other tables. Almighty, Passive, and Support are not included in the table header since they can be inherited by any type, but Almighty inheritance types will still have this table. Rare personas do not have this table, since they don't inherit anything. Fixes #37

Also fixes an issue with Leanan Sidhe's itemization where it wasn't properly flagged as a skill card. Item maps also have had the unused skill card entries removed since the data is being pulled from the skill map.

chinhodado commented 1 year ago

Thanks!