Closed ricardogobbosouza closed 2 years ago
/cc @chinleung
@ricardogobbosouza Hey! 👋🏼
Thanks for the contribution. It seems like the tests are failing after your fix though. Can you fix them please? 😄
https://github.com/chinleung/laravel-multilingual-routes/runs/4166924873?check_suite_focus=true
@chinleung Add a check to see if the methods exists setBindingFields
and bindingFields
They have been added in laravel >= 7.1
It might be interesting to release a new version in the future deprecating laravel 5 and 6 =)
@chinleung Add a check to see if the methods exists
setBindingFields
andbindingFields
They have been added in laravel >= 7.1
Thanks!
It might be interesting to release a new version in the future deprecating laravel 5 and 6 =)
Yeah I'll do that for the next version of Laravel. I think it might break stuff for people if I suddenly remove the support of Laravel 7 and 8 from v2. 😢
It would have to be v3 =)
Resolve #61