search

chinleung / laravel-multilingual-routes

A package to handle multilingual routes in your Laravel application.
https://github.com/chinleung/laravel-multilingual-routes-demo
MIT License
401 stars 25 forks source link

fix: preserve binding fields #62

Closed ricardogobbosouza closed 3 years ago

ricardogobbosouza commented 3 years ago

Resolve #61

ricardogobbosouza commented 3 years ago

/cc @chinleung

chinleung commented 3 years ago

@ricardogobbosouza Hey! 👋🏼

Thanks for the contribution. It seems like the tests are failing after your fix though. Can you fix them please? 😄

https://github.com/chinleung/laravel-multilingual-routes/runs/4166924873?check_suite_focus=true

ricardogobbosouza commented 3 years ago

@chinleung Add a check to see if the methods exists setBindingFields and bindingFields They have been added in laravel >= 7.1

ricardogobbosouza commented 3 years ago

It might be interesting to release a new version in the future deprecating laravel 5 and 6 =)

chinleung commented 3 years ago

@chinleung Add a check to see if the methods exists setBindingFields and bindingFields They have been added in laravel >= 7.1

Thanks!

It might be interesting to release a new version in the future deprecating laravel 5 and 6 =)

Yeah I'll do that for the next version of Laravel. I think it might break stuff for people if I suddenly remove the support of Laravel 7 and 8 from v2. 😢

ricardogobbosouza commented 3 years ago

It would have to be v3 =)