chinleung / laravel-multilingual-routes

A package to handle multilingual routes in your Laravel application.
https://github.com/chinleung/laravel-multilingual-routes-demo
MIT License
401 stars 25 forks source link

Bugfix: prevent double prefix in route cache #69

Closed ghost closed 2 years ago

ghost commented 2 years ago

Fixes #68

Routes that are registered by Laravel's route registrar don't contain the prefix in the cached routes file and the ones by the package do.

This MR removes the prefix from the route's action payload after registering so once it's being serialized there's no referral left to the original prefix. The URI is at that point in time already prefixed.

I looked into your test and can't seem to find any point where you test cached routes so I'm not really sure how to write a test for this and if it even should be tested in the package since its framework behavior.