search

chinloyal / pusher_client

A Pusher Channels Client for Fluttter (Fully supports Android and iOS)
https://pusher.com/channels
MIT License
43 stars 175 forks source link

Why include log4j12 dependency? #3

Closed spiritinlife closed 3 years ago

spiritinlife commented 3 years ago

I am considering using this library, but i am not sure why is log4j12 used?

spiritinlife commented 3 years ago

Also when minifyEnabled=true, i get Caused by: java.lang.ClassNotFoundException: Didn't find class "org.apache.log4j.Category" on path: DexPathList

chinloyal commented 3 years ago

The configuration for this is mentioned in the read me here It speaks to what to do if minifyEnabled is true

spiritinlife commented 3 years ago

Yes I understand that, but how is log4j used in the plugin ? Is it necessary ?

chinloyal commented 3 years ago

I may have installed it for logging but I'm realizing that I had used android.util.Log instead so I may have installed log4j but forgot to remove it.

chinloyal commented 3 years ago

I'll remove it