fixed infinite loop when jQuery is loaded

chinmaymk / angular-charts

angular directives for creating common charts using d3

MIT License

1.03k stars 270 forks source link

fixed infinite loop when jQuery is loaded #187

Closed moumar closed 9 years ago

moumar commented 9 years ago

this will fix #154

stormboy commented 9 years ago

This is an important fix. I just spent a while narrowing down a JS lock-up and arrived at the exact same code change. I am using bower to include this module. Please merge.

aclemmer commented 9 years ago

Please merge. Also seeing the issue on angular 1.2.28; this fixes it.

soyuka commented 9 years ago

Merged but I can't publish to bower.

moumar commented 9 years ago

when using jQuery, additional props are added to arrays returned by .find() and are reached with "for(var i in ...)" syntax, causing an infinite loop. Proper "for" syntax fixes it.

zzzaaa commented 9 years ago

+1 for bower package

philippecarle commented 9 years ago

+1 for bower package………

abhisharma2 commented 9 years ago

yes +1. updating bower would be great!

PanfilovDenis commented 9 years ago

+1 update bower package plz!