search

chinmaymk / angular-charts

angular directives for creating common charts using d3
MIT License
1.03k stars 270 forks source link

if title is false height ist not correct in setContainers #228

Open hesst opened 7 years ago

hesst commented 7 years ago

https://github.com/chinmaymk/angular-charts/blob/master/src/angular-charts.js#L189 if title is false then the div

{{acConfig.title}}

is commented out then getChildrenByClassname(childrens, 'ac-title') returns the last existing element from parameter childrens (thats another bug I think) hight is sybstracted by the clientHeight of this (improper) element