search

chip-8 / chip-8-database

A database of CHIP-8 ROM metadata
Other
17 stars 3 forks source link

Use integers over strings for hash->index mappings, for ease of use in more typed environments #15

Closed Estus-Dev closed 1 year ago

Estus-Dev commented 1 year ago

The file sha1-hashes.json is used to map from a hash string to an index into the contents of programs.json.

However, in an environment like Rust with serde, the string typing of the indicies in this file require jumping through some minor hoops to parse them as intended.

Those hoops aren't blockers by any stretch, but this is the easiest place to resolve that problem so that's what I'm trying first.

Estus-Dev commented 1 year ago

Apologies for the force-push, I pushed these changes to my main branch so I could depend on them from another project. Which of course made it very easy to accidentally commit and push unrelated changes, which I then immediately unpushed.

I should have made a separate branch just for this PR.