search

chip-8 / chip-8-database

A database of CHIP-8 ROM metadata
Other
17 stars 3 forks source link

Updated Database to include Chip8AllInOne.ch8 #17

Closed GamingMadster closed 3 months ago

GamingMadster commented 3 months ago

Yup, updated the database to include a singular new rom. Should be all good to merge, although I'm uncertain if my hash being all uppercase is an issue or not.

I got confirmation that it's all good.

GamingMadster commented 3 months ago

Probably not your fault, but this PR ended up massive, and I don't know why at a glance.

I'll dig in later to figure out why it seems to be readding a bunch of ROMs that were already there. Not to mention all the node_modules files that were added somehow.

What platform did you submit this from out of curiosity?

I planned to do this under Ubuntu, but I ended up doing it under Windows since my linux install hit the wall again.

Estus-Dev commented 3 months ago

I've just confirmed that the DB is up to date and I can't recreate this issue, so for now I'd say just copy the entry you made to programs.json and make a new PR with just that. Run npm run format and nothing else, and only commit the one change to programs.json.