search

chip-8 / chip-8-database

A database of CHIP-8 ROM metadata
Other
17 stars 3 forks source link

New PR, Readded Chip8AllInOne.ch8 #18

Closed GamingMadster closed 3 months ago

GamingMadster commented 3 months ago

Still no clue why those hashes got all screwed. Hopefully all is good now :D

GamingMadster commented 3 months ago

...and apparently it says I changed 14k lines of the JSON. Neat.

Estus-Dev commented 3 months ago

...and apparently it says I changed 14k lines of the JSON. Neat.

Well it looks like you added 11 and modified 7,282. They just show up as added and removed when you change them.

Without pulling it down to verify, it looks like it's line endings. Try setting your editor to use \n (Unix-style) endings rather than \r\n (Windows-style) and reformat the file. Also set git to convert \r\n line endings to \n when committing, most projects will expect that.

GamingMadster commented 3 months ago

...and apparently it says I changed 14k lines of the JSON. Neat.

Well it looks like you added 11 and modified 7,282. They just show up as added and removed when you change them.

Without pulling it down to verify, it looks like it's line endings. Try setting your editor to use \n (Unix-style) endings rather than \r\n (Windows-style) and reformat the file. Also set git to convert \r\n line endings to \n when committing, most projects will expect that.

Pretty sure I fixed it, or well, I hope so anyway.

Timendus commented 3 months ago

Thanks for your contribution Madster! Hope the next one goes more smoothly :smile: