search

chip8-rust / chip8-ui

CHIP-8 graphical emulator built with the Rust programing language
MIT License
8 stars 0 forks source link

Fixes for rustc nightly #1

Closed robo9k closed 9 years ago

robo9k commented 9 years ago

I've tried running the current HEAD with today's rustc:

$ rustc --version
rustc 1.0.0-nightly (eaf4c5c78 2015-02-02 15:04:54 +0000)

Yet the dependencies would not compile at all, so I did a cargo --update. Next I'd get one compiler error and one warning:

src/ops.rs:47:10: 47:14 warning: derive(Show) is deprecated in favor of derive(Debug)
src/ops.rs:47 #[derive(Show)]
                       ^~~~
src/main.rs:4:12: 4:23 error: unused or unknown feature, #[deny(unused_features)] on by default
src/main.rs:4 #![feature(collections)]
                         ^~~~~~~~~~~

With those changes in place the compiled binary and unit tests work. Let's see how long :smile:

jakerr commented 9 years ago

Awesome!

FYI my rust nightly fetched with multirust on mac is on a different version

> rustc --version
rustc 1.0.0-nightly (f1398d273 2015-01-31 20:21:02 +0000)

But I pulled your change and it works for me there too. Thanks so much! :)