search

chip8-rust / chip8-ui

CHIP-8 graphical emulator built with the Rust programing language
MIT License
8 stars 0 forks source link

Split UI and VM in separate crates #4

Closed robo9k closed 9 years ago

robo9k commented 9 years ago

This implements most of the points in #3.

I was not aware that crates on crates.io can not have git dependencies, so chip8_ui can not be uploaded. I tried using the crates.io versions of all dependencies instead, but they're not recent enough (I'll add another issue for that).

So for now, the chip8_vm crate on crates.io would need @jakerr as another crate owner. You'll need to login to crates.io to create an account before I can add you.

The commits b779bbd and ca4ce39 were required to work with latest rustc nightly alongside some upstream pull requests.

Please feel free to ask questions or suggest further changes to this pull request!

jakerr commented 9 years ago

This looks excellent. Thanks so much for doing this and for the detailed commit messages and links to documentation!

I signed up for crates.io account so you can add me as co-owner whenever you get the chance.

jakerr commented 9 years ago

I've answered all my own questions after some more poking around. Looks good!

robo9k commented 9 years ago

I signed up for crates.io account so you can add me as co-owner whenever you get the chance.

Added you as an owner. You're already showing up on the chip8_vm crate page and in cargo owner --list, so it seems to work.