search

chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Pontech variants #293

Closed JacobChrist closed 8 years ago

JacobChrist commented 8 years ago

This pull request address issue #292. It also does some minor refactor of other PONTECH variants so that the folder naming convention is consistent from board to board.

chipkitbot commented 8 years ago

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/182/.

EmbeddedMan commented 8 years ago

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

JacobChrist commented 8 years ago

The MZ code is from Keith I just split it up. Seems to be working for at least 5 ADC channels we are using. Sine there is really no MZ board and the WiFire code is untouched I am pretty sure nothing is broken.

Jacob

On Nov 27, 2016 2:06 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293#issuecomment-263151135, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa9c4PJIPxwYlXBTDCA07yGXnW1VRks5rCf7NgaJpZM4KxARk .

JacobChrist commented 8 years ago

As a matter of fact the the function names still say WiFire. A fact I realized recently and should have renamed them to be more generic. This is for another issue though....

On Nov 27, 2016 4:31 PM, "Jacob Christ" jacob@pontech.com wrote:

The MZ code is from Keith I just split it up. Seems to be working for at least 5 ADC channels we are using. Sine there is really no MZ board and the WiFire code is untouched I am pretty sure nothing is broken.

Jacob

On Nov 27, 2016 2:06 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293#issuecomment-263151135, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa9c4PJIPxwYlXBTDCA07yGXnW1VRks5rCf7NgaJpZM4KxARk .

EmbeddedMan commented 8 years ago

Jacob,

Understood - that the intent was only to change behavior for MZ parts. But from my (brief) code review, it looks like non-MZ parts will also have some limited changes in the overall flow through ReadAnalog. Have you tested on at least one non-MZ board to make sure all existing analog functionality remains working?

*Brian

On Sun, Nov 27, 2016 at 6:37 PM, Jacob Christ notifications@github.com wrote:

As a matter of fact the the function names still say WiFire. A fact I realized recently and should have renamed them to be more generic. This is for another issue though....

On Nov 27, 2016 4:31 PM, "Jacob Christ" jacob@pontech.com wrote:

The MZ code is from Keith I just split it up. Seems to be working for at least 5 ADC channels we are using. Sine there is really no MZ board and the WiFire code is untouched I am pretty sure nothing is broken.

Jacob

On Nov 27, 2016 2:06 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263151135, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAMGa9c4PJIPxwYlXBTDCA07yGXnW1VRks5rCf7NgaJpZM4KxARk .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293#issuecomment-263159984, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCP4ZbcXrq2U0z6kOJ2ZF7_-7aEOVks5rCiJVgaJpZM4KxARk .

JacobChrist commented 8 years ago

I have not. I have tested one channel on at least 3 mx boards. I can do this check tomorrow.

Jacob

On Nov 27, 2016 5:03 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob,

Understood - that the intent was only to change behavior for MZ parts. But from my (brief) code review, it looks like non-MZ parts will also have some limited changes in the overall flow through ReadAnalog. Have you tested on at least one non-MZ board to make sure all existing analog functionality remains working?

*Brian

On Sun, Nov 27, 2016 at 6:37 PM, Jacob Christ notifications@github.com wrote:

As a matter of fact the the function names still say WiFire. A fact I realized recently and should have renamed them to be more generic. This is for another issue though....

On Nov 27, 2016 4:31 PM, "Jacob Christ" jacob@pontech.com wrote:

The MZ code is from Keith I just split it up. Seems to be working for at least 5 ADC channels we are using. Sine there is really no MZ board and the WiFire code is untouched I am pretty sure nothing is broken.

Jacob

On Nov 27, 2016 2:06 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263151135, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAMGa9c4PJIPxwYlXBTDCA07yGXnW1VRks5rCf7NgaJpZM4KxARk .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263159984, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCP4ZbcXrq2U0z6kOJ2ZF7_-7aEOVks5rCiJVgaJpZM4KxARk .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293#issuecomment-263161921, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa0tZyVPWbNLnj_0fBcdCQCmlh9Shks5rCihqgaJpZM4KxARk .

EmbeddedMan commented 8 years ago

Thanks Jacob. If you find any problems, file a new issue so we can track any changes that are needed.

*Brian

On Sun, Nov 27, 2016 at 8:40 PM, Jacob Christ notifications@github.com wrote:

I have not. I have tested one channel on at least 3 mx boards. I can do this check tomorrow.

Jacob

On Nov 27, 2016 5:03 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob,

Understood - that the intent was only to change behavior for MZ parts. But from my (brief) code review, it looks like non-MZ parts will also have some limited changes in the overall flow through ReadAnalog. Have you tested on at least one non-MZ board to make sure all existing analog functionality remains working?

*Brian

On Sun, Nov 27, 2016 at 6:37 PM, Jacob Christ notifications@github.com wrote:

As a matter of fact the the function names still say WiFire. A fact I realized recently and should have renamed them to be more generic. This is for another issue though....

On Nov 27, 2016 4:31 PM, "Jacob Christ" jacob@pontech.com wrote:

The MZ code is from Keith I just split it up. Seems to be working for at least 5 ADC channels we are using. Sine there is really no MZ board and the WiFire code is untouched I am pretty sure nothing is broken.

Jacob

On Nov 27, 2016 2:06 PM, "Brian Schmalz" notifications@github.com wrote:

Jacob, this all looks good to me, although I don't understand enough about our analog code and the PIC32's analog peripheral to know everything is correct.

How much testing with analog reads did you do on non-MZ boards?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263151135, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAMGa9c4PJIPxwYlXBTDCA07yGXnW1VRks5rCf7NgaJpZM4KxARk .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263159984, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCP4ZbcXrq2U0z6kOJ2ZF7_-7aEOVks5rCiJVgaJpZM4KxARk .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293# issuecomment-263161921, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGa0tZyVPWbNLnj_ 0fBcdCQCmlh9Shks5rCihqgaJpZM4KxARk .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/293#issuecomment-263170948, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCFzzq1i53iOfOgIrK9uTxudZSeB9ks5rCj8cgaJpZM4KxARk .