search

chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Replaced interrupt attributes with __USER_ISR #352

Closed majenkotech closed 7 years ago

majenkotech commented 7 years ago

Pretty much all instances of interrupts in the core and libraries had manual __attribute__ based interrupt stubs. These all lacked the section attribute (for MZ boards) to force the interrupt into an addressable area, so large blobs of rodata could shift ISRs into an unusable area causing the chip to crash horribly.

Switching them all to use the macro __USER_ISR ensures that they all have the right section added when needed.

Affected:

EmbeddedMan commented 7 years ago

@majenkotech we (actually @lstandage ) will be doing some testing on this one before we merge it in. That should start pretty soon.

EmbeddedMan commented 7 years ago

@lstandage Can you document (here) the various boards and sketches that you used to confirm that these changes don't cause problems for any bits of code that involve interrupts?

EmbeddedMan commented 7 years ago

Larry, are you certain that this is OK to merge? I thought you were going to test it with some sketches - even Matt says it needs to be completely tested before it gets merged.

lstandage commented 7 years ago

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

EmbeddedMan commented 7 years ago

OK, can you post the sketch here so that there's a record of what sketch and which boards were used to test that everything worked?

Thanks-

On Wed, Jun 7, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-306977676, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCLA1FuvzGajDKBbFVpyHEOs08amQks5sB1fHgaJpZM4NaDq0 .

lstandage commented 7 years ago

I'm getting an odd problem when I copy the core files (with Matt's changes) over to the Arduino directories to test out the change. What I get is the following:

Arduino: 1.8.3 (Windows 7), Board: "chipKIT WiFire"

C:\Program Files (x86)\Arduino\arduino-builder -dump-prefs -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino C:\Program Files (x86)\Arduino\arduino-builder -compile -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino Using board 'chipkit_WiFire' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1 Using core 'pic32' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1 Build options changed, rebuilding all Detecting libraries used... "C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\WiFiScanExpanded.ino.cpp" -o "nul" Generating function prototypes... "C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\WiFiScanExpanded.ino.cpp" -o "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\preproc\ctags_target_for_gcc_minus_e.cpp" exec: "C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++": file does not exist Error compiling for board chipKIT WiFire.

Does any of this make sense? I don't understand why it suddenly can't find pic32-g++, when it found it earlier.

On Wed, Jun 7, 2017 at 7:10 PM, Brian Schmalz notifications@github.com wrote:

OK, can you post the sketch here so that there's a record of what sketch and which boards were used to test that everything worked?

Thanks-

On Wed, Jun 7, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977676, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCLA1FuvzGajDKBbFVpyHEOs08amQks5sB1fHgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-306977903, or mute the thread https://github.com/notifications/unsubscribe-auth/ALyFRYlOOn46PbV1HXPrzo7_HeYOSFVbks5sB1gpgaJpZM4NaDq0 .

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

EmbeddedMan commented 7 years ago

What files did you copy over? Before the copy, was it working? The errors you're getting look like the type of errors you get if you were to swap platform.txt files between ZIP and JSON distributions of chipKIT-core.

On Thu, Jun 8, 2017 at 5:46 PM, lstandage notifications@github.com wrote:

I'm getting an odd problem when I copy the core files (with Matt's changes) over to the Arduino directories to test out the change. What I get is the following:

Arduino: 1.8.3 (Windows 7), Board: "chipKIT WiFire"

C:\Program Files (x86)\Arduino\arduino-builder -dump-prefs -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino C:\Program Files (x86)\Arduino\arduino-builder -compile -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino Using board 'chipkit_WiFire' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Using core 'pic32' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Build options changed, rebuilding all Detecting libraries used... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "nul" Generating function prototypes... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "C:\Users\c15009\AppData\Local\Temp\arduinobuild 870996\preproc\ctags_target_for_gcc_minus_e.cpp" exec: "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++": file does not exist Error compiling for board chipKIT WiFire.

Does any of this make sense? I don't understand why it suddenly can't find pic32-g++, when it found it earlier.

On Wed, Jun 7, 2017 at 7:10 PM, Brian Schmalz notifications@github.com wrote:

OK, can you post the sketch here so that there's a record of what sketch and which boards were used to test that everything worked?

Thanks-

On Wed, Jun 7, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977676, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCLA1FuvzGajDKBbFVpyHEOs08amQks5sB1fHgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977903, or mute the thread https://github.com/notifications/unsubscribe- auth/ALyFRYlOOn46PbV1HXPrzo7_HeYOSFVbks5sB1gpgaJpZM4NaDq0 .

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-307247857, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCOm393n62j4MOP-POW0xhKAdTkI8ks5sCHnCgaJpZM4NaDq0 .

lstandage commented 7 years ago

That was it! Now I know when I sync between core and installed versions to exclude that file.

On Thu, Jun 8, 2017 at 3:58 PM, Brian Schmalz notifications@github.com wrote:

What files did you copy over? Before the copy, was it working? The errors you're getting look like the type of errors you get if you were to swap platform.txt files between ZIP and JSON distributions of chipKIT-core.

On Thu, Jun 8, 2017 at 5:46 PM, lstandage notifications@github.com wrote:

I'm getting an odd problem when I copy the core files (with Matt's changes) over to the Arduino directories to test out the change. What I get is the following:

Arduino: 1.8.3 (Windows 7), Board: "chipKIT WiFire"

C:\Program Files (x86)\Arduino\arduino-builder -dump-prefs -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino C:\Program Files (x86)\Arduino\arduino-builder -compile -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32-tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\WiFiScanExpanded.ino Using board 'chipkit_WiFire' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Using core 'pic32' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Build options changed, rebuilding all Detecting libraries used... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "nul" Generating function prototypes... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "C:\Users\c15009\AppData\Local\Temp\arduinobuild 870996\preproc\ctags_target_for_gcc_minus_e.cpp" exec: "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++": file does not exist Error compiling for board chipKIT WiFire.

Does any of this make sense? I don't understand why it suddenly can't find pic32-g++, when it found it earlier.

On Wed, Jun 7, 2017 at 7:10 PM, Brian Schmalz notifications@github.com wrote:

OK, can you post the sketch here so that there's a record of what sketch and which boards were used to test that everything worked?

Thanks-

On Wed, Jun 7, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977676, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCLA1FuvzGajDKBbFVpyHEOs08amQks5sB1fHgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977903, or mute the thread https://github.com/notifications/unsubscribe- auth/ALyFRYlOOn46PbV1HXPrzo7_HeYOSFVbks5sB1gpgaJpZM4NaDq0 .

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-307247857, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCOm393n62j4MOP- POW0xhKAdTkI8ks5sCHnCgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-307249902, or mute the thread https://github.com/notifications/unsubscribe-auth/ALyFRd88fLCl1hJYYo2Jog7Sagv75HV_ks5sCHytgaJpZM4NaDq0 .

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

EmbeddedMan commented 7 years ago

Great!

On Thu, Jun 8, 2017 at 6:28 PM, lstandage notifications@github.com wrote:

That was it! Now I know when I sync between core and installed versions to exclude that file.

On Thu, Jun 8, 2017 at 3:58 PM, Brian Schmalz notifications@github.com wrote:

What files did you copy over? Before the copy, was it working? The errors you're getting look like the type of errors you get if you were to swap platform.txt files between ZIP and JSON distributions of chipKIT-core.

On Thu, Jun 8, 2017 at 5:46 PM, lstandage notifications@github.com wrote:

I'm getting an odd problem when I copy the core files (with Matt's changes) over to the Arduino directories to test out the change. What I get is the following:

Arduino: 1.8.3 (Windows 7), Board: "chipKIT WiFire"

C:\Program Files (x86)\Arduino\arduino-builder -dump-prefs -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32- tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\ WiFiScanExpanded.ino C:\Program Files (x86)\Arduino\arduino-builder -compile -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -hardware C:\Users\c15009\AppData\Local\Arduino15\packages -hardware C:\Users\c15009\Documents\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -tools C:\Users\c15009\AppData\Local\Arduino15\packages -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\c15009\Documents\Arduino\libraries -fqbn=chipKIT:pic32:chipkit_WiFire -ide-version=10803 -build-path C:\Users\c15009\AppData\Local\Temp\arduino_build_870996 -warnings=all -build-cache C:\Users\c15009\AppData\Local\Temp\arduino_cache_758007 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.pic32prog.path=C:\Users\c15009\AppData\Local\ Arduino15\packages\chipKIT\tools\pic32prog\v2.1.24 -prefs=runtime.tools.pic32-tools.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\pic32- tools\1.43-pic32gcc -prefs=runtime.tools.drivers-windows.path=C:\Users\c15009\ AppData\Local\Arduino15\packages\chipKIT\tools\drivers-windows\v2 -verbose C:\Projects\chipKIT\Core\WiFiScanExpanded\ WiFiScanExpanded.ino Using board 'chipkit_WiFire' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Using core 'pic32' from platform in folder: C:\Users\c15009\AppData\Local\Arduino15\packages\chipKIT\ hardware\pic32\1.4.1 Build options changed, rebuilding all Detecting libraries used... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "nul" Generating function prototypes... "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++" -c -g -O2 -w -DARDUINO_ARCH_PIC32 -mno-smart-io -ffunction-sections -fdata-sections -mdebugger -Wcast-align -fno-short-double -ftoplevel-reorder -fno-exceptions -w -x c++ -E -CC -mprocessor=32MZ2048EFG100 -DF_CPU=200000000UL -DARDUINO=10803 -D_BOARDWIFIRE -DARDUINO_ARCH_PIC32 -DMPIDEVER=16777998 -DMPIDE=150 -DIDE=Arduino -IC:\Users\c15009\AppData\Local\Temp\arduino_build_870996/sketch "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\cores\pic32" "-IC:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32\1.4.1\variants\WiFire" "C:\Users\c15009\AppData\Local\Temp\arduino_build_870996\sketch\ WiFiScanExpanded.ino.cpp" -o "C:\Users\c15009\AppData\Local\Temp\arduinobuild 870996\preproc\ctags_target_for_gcc_minus_e.cpp" exec: "C:\Users\c15009\AppData\Local\Arduino15\packages\ chipKIT\hardware\pic32/pic32/compiler/pic32-tools/bin/pic32-g++": file does not exist Error compiling for board chipKIT WiFire.

Does any of this make sense? I don't understand why it suddenly can't find pic32-g++, when it found it earlier.

On Wed, Jun 7, 2017 at 7:10 PM, Brian Schmalz < notifications@github.com> wrote:

OK, can you post the sketch here so that there's a record of what sketch and which boards were used to test that everything worked?

Thanks-

On Wed, Jun 7, 2017 at 9:09 PM, lstandage notifications@github.com wrote:

I tested it with the sketch David Powell gave us, and was able to get it to work.

I can run a few more tests, but I'm satisfied.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977676, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAbeCLA1FuvzGajDKBbFVpyHEOs08amQks5sB1fHgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-306977903, or mute the thread https://github.com/notifications/unsubscribe- auth/ALyFRYlOOn46PbV1HXPrzo7_HeYOSFVbks5sB1gpgaJpZM4NaDq0 .

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-307247857, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCOm393n62j4MOP- POW0xhKAdTkI8ks5sCHnCgaJpZM4NaDq0 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352# issuecomment-307249902, or mute the thread https://github.com/notifications/unsubscribe-auth/ ALyFRd88fLCl1hJYYo2Jog7Sagv75HV_ks5sCHytgaJpZM4NaDq0

.

-- "It is not necessary to change. Survival is not mandatory." - W. Edwards Deming

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-307254790, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCJJz86rZII0BjsS1oNgzOjUqTWTrks5sCIOpgaJpZM4NaDq0 .

lstandage commented 7 years ago

Here is the sketch used to test it. Without these changes, the sketch fails on WiFire.

I went back and tested on uC32 (with WiFi shield) and on WF32, to make sure they still worked, and they do.

WiFiScanExpanded.zip

EmbeddedMan commented 7 years ago

Larry, I couldn't find the original WiFIScanExpanded.ino file. Can you describe the changes you made in order to get it to work?

Also, what interrupts does this sketch test? I see that the serial interrupt is commented out.

*Brian

On Thu, Jun 8, 2017 at 6:38 PM, lstandage notifications@github.com wrote:

Here is the sketch used to test it. Without these changes, the sketch fails on WiFire.

I went back and tested on uC32 (with WiFi shield) and on WF32, to make sure they still worked, and they do.

WiFiScanExpanded.zip https://github.com/chipKIT32/chipKIT-core/files/1062661/WiFiScanExpanded.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/352#issuecomment-307256300, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCLRJhcJhXyY5GSdyay_4eSAwynm5ks5sCIX8gaJpZM4NaDq0 .

squintz commented 7 years ago

For my test case what I have done is added a header file like Matt mentioned doing in a previous e-mail. The header basically contains this:

const PROGMEM short image16[] = { 0x6ad3, 0x45aa, 0x4dec, 0x4189, 0x49eb, 0x45cb, 0x49cb, 0x49ec,

with 48,000 lines of data. I calculate that out to match the 768000 bytes in Matt's test case.

Then in the Setup section of the WiFiScan example I added a println because I don't have an lcd display for testing the loading of an image into memory and I wanted to make sure I actually loaded the data. If I only print 1 or 2 bytes then the large header is optimized out making the code space used only 4% and the code runs fine. But if I print 10 bytes then the compiler reports that the program space used is 41% and with core 1.4.1 (not including Matt's changes) the Wi-Fire crashes.

for (i=0; i < 10; i++){ Serial.println(image16[i]); }

I also added but later commented out the following:

Serial1.attachInterrupt(myCallback);

void myCallback(int c) 
{
// do nothing
}

The reason I commented this out was because with 1.4.1 I was able to crash the Wi-Fire processor without this line of code. So I wanted to keep things simple for testing and not add complexities that could cause confusion.

My test of Matt's changes did not work and so I'm going to make another attempt at it today. It's mostly likely due to me manually making the changes to the core and messing something up since it seems Larry was able to successfully test with my sketch.

David

squintz commented 7 years ago

I was able to successfully run my test sketch with Matt's changes. I'll continue testing with other boards but at least for the WF32 and Wi-Fire this merge is working.