chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Implement Print::availableForWrite #353

Closed eric-wieser closed 7 years ago

eric-wieser commented 7 years ago

This was added in arduino/Arduino#5789

Not implemented yet for USB serial, as that is harder.

That shouldn't stop this patch being merged though - without this change, some Arduino code won't even compile.

EmbeddedMan commented 7 years ago

This seems just fine to me. @majenkotech any issues with this PR?

majenkotech commented 7 years ago

Looks good to me. Simple test of the TX buffer full bit, and a virtual default function.

Not sure how we would go about implementing this for the USB though - have to dig into the TX implementation.

EmbeddedMan commented 7 years ago

Agreed. That's going to be a bit more work.