search

chipKIT32 / chipKIT-core

Downloadable chipKIT core for use with Arduino 1.6 - 1.8+ IDE, PlatformIO, and UECIDE
http://chipkit.net/
Apache License 2.0
59 stars 53 forks source link

Reinstated missing E2END #400

Closed majenkotech closed 6 years ago

majenkotech commented 6 years ago

The E2END macro got accidentally left out of the new cpudefs.h file. This breaks EEPROM.

Quite why this is in the core and not either in the linker script (where the EEPROM size is defined) or the EEPROM library is anyone's guess - but it is... or was...

EmbeddedMan commented 6 years ago

I think the reason it's not in a linker script is because we wanted it to be a constant value across all chipKIT boards, since we want sketches to be able to depend on it.

Maybe putting it in the EEPROM library would be a better idea though - since any sketch that uses EEPROM will use that EEPROM library, right? But in actuality, it's also 'used' in the linker script. There are multiple places that need to know this number, and it would be great to only have one place with one number. I'm just not sure I know how to easily do that at this point.

So I think this is good enough .